-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 🎨 update model alias handling logic #952
Conversation
@@ -81,9 +81,10 @@ By default, GenAIScript supports the following model aliases: | |||
- `large`: `gpt-4o like` model | |||
- `small`: `gpt-4o-mini` model or similar. A smaller, cheaper faster model | |||
- `vision`: `gpt-4o-mini`. A model that can analyze images | |||
- `reasoning`: `o1` or `o1-preview`. | |||
- `reasoning-small`: `o1-mini`. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model aliases reasoning
and reasoning-small
are not clearly defined. It's unclear what models they map to (o1
, o1-preview
, o1-mini
). Consider providing more details or examples for clarity.
generated by pr-docs-review-commit
model_alias_confusion
@@ -76,14 +76,16 @@ An model alias can reference another alias as long as cycles are not created. | |||
|
|||
## Builtin aliases | |||
|
|||
By default, GenAIScript supports the following model aliases: | |||
By default, GenAIScript supports the following model aliases, and various candidates | |||
in different LLM providers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rephrasing the sentence to improve clarity and flow. For example: "By default, GenAIScript supports the following model aliases, including various candidates from different LLM providers."
generated by pr-docs-review-commit
improvement
|
||
The following aliases are also set so that you can override LLMs used by GenAIScript itself. | ||
|
||
- `reasoning`: `large`. In the future, `o1` like models. | ||
- `agent`: `large`. Model used by the Agent LLM. | ||
- `memory`: `small`. Moel used by the agent short term memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence is grammatically correct but could be clearer. Consider rephrasing it to improve readability. For example: "These aliases are also set so that you can override the LLMs used by GenAIScript itself."
generated by pr-docs-review-commit
improvement
define reasoning, reasoning-small models
candidates
properties to all model configurations (large
,small
,vision
,embeddings
,reasoning
, andreasoning-small
) to support multiple model options and improve flexibility.model-aliases.mdx
file to reflect the newreasoning
andreasoning-small
aliases, ensuring consistency and clarity in model usage descriptions.