Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON5 helper #964

Merged
merged 3 commits into from
Dec 22, 2024
Merged

JSON5 helper #964

merged 3 commits into from
Dec 22, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Dec 22, 2024


• Added JSON5 support for parsing and stringifying objects. 🔄
• Introduced a deleteEmptyValues function to clean up empty values in an object. ⚡️
• Updated the MD, JSONL, and JSON5 interfaces to reflect the new additions. 🔨
• Created a sample file (globals.genai.mjs) demonstrating JSON5 usage with parsing and stringification checks. 📝

AI-generated content by pr-describe may be incorrect

Copy link

LGTM 🚀

The changes look good to me. Here are the summarized points:

  1. Added TypeScript interfaces for JSON5: This will help in providing type safety while parsing and stringifying JSON5 data.
  2. Enhanced utility functions: deleteEmptyValues has been modified to correctly handle object types, which is essential for removing empty values recursively.
  3. Reorganized imports: The pull request includes a clearer and more organized import statement for JSON5.
  4. Code readability improvements: The addition of type annotations in interfaces and utility function parameters enhances readability and maintainability.

Overall, the changes improve the functionality and robustness of the codebase without introducing any new issues.

AI-generated content by pr-review may be incorrect

@pelikhan pelikhan merged commit 8a92fd8 into main Dec 22, 2024
14 checks passed
@pelikhan pelikhan deleted the json5object branch December 22, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant