Fix error checks during certificatePath reading and parsing in azuread #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 74.87% 74.53% -0.35%
==========================================
Files 32 31 -1
Lines 6397 6388 -9
==========================================
- Hits 4790 4761 -29
- Misses 1325 1338 +13
- Partials 282 289 +7 ☔ View full report in Codecov by Sentry. |
|
thx for the PR. Yikes, this is a bad test hole. Can you pls add a test to at least verify the negative case of a missing cert? |
jegorbunov
force-pushed
the
azuread-fix-certificate-path-error-checks
branch
from
0850e76 to
9a09d6f
Compare
@microsoft-github-policy-service agree |
No worries. Added a simple test. |
jegorbunov
force-pushed
the
azuread-fix-certificate-path-error-checks
branch
from
9a09d6f to
009f5cd
Compare
shueybubbles
approved these changes
Nov 26, 2024
|
@shueybubbles, when can I expect this change to be released / tagged? Thanks! |
|
i have another PR to prep for v1.8.0 #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR certificate-based authentication (in case of a
ActiveDirectoryServicePrincipalorActiveDirectoryApplicationfed auth) would panic (nil pointer dereference atgithub.com/microsoft/[email protected]/azuread/configuration.go:228) because of wrong error checks.