Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMe and resource disc testcase fixes #3432

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

SRIKKANTH
Copy link
Collaborator

@SRIKKANTH SRIKKANTH commented Sep 20, 2024

NVMe and resource disc testcase fixes

  1. Added new testcase "Nvme.verify_nvme_function_unpartitioned".
  2. NVMe test case fixes for disc controller type NVMe.
  3. "Nvme.verify_nvme_fstrim" - use fstrim testfile size based on available space.
  4. Resource disc testcases fixes for VMs with Local NVMEs.
  5. Added below new methods:
    a. check_resource_disk_mounted
    b. get_resource_disks
    c. get_resource_disk_type
    d. get_disk_type
    e. _remove_nvme_os_disk
    f. _get_os_disk_nvme_device
    g. _verify_nvme_function

@SRIKKANTH
Copy link
Collaborator Author

SRIKKANTH commented Sep 20, 2024

This PR has a dependency on #3420

Please merge #3420 before accepting this PR so that lspci changes are part of different PR. and not clubbed with NVMe changes

@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch from c7e4a17 to bd7d0e2 Compare September 24, 2024 04:20
@SRIKKANTH SRIKKANTH marked this pull request as draft October 23, 2024 03:28
@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch 2 times, most recently from f76263a to 5855bb7 Compare October 23, 2024 03:42
@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch 5 times, most recently from b402609 to b29f14e Compare November 12, 2024 11:39
@SRIKKANTH SRIKKANTH marked this pull request as ready for review November 12, 2024 11:45
@SRIKKANTH SRIKKANTH changed the title NVMe testcase fixes for ASAP VMs NVMe and resource disc testcase fixes Nov 12, 2024
lisa/features/nvme.py Outdated Show resolved Hide resolved
@SRIKKANTH SRIKKANTH marked this pull request as draft November 20, 2024 12:11
@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch from cda3e20 to 0756836 Compare November 20, 2024 19:32
@SRIKKANTH SRIKKANTH marked this pull request as ready for review November 20, 2024 19:42
lisa/features/disks.py Outdated Show resolved Hide resolved
@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch from 9374321 to 26b336a Compare November 23, 2024 12:38
NVMe and resource disc testcase fixes

1. Added new testcase "Nvme.verify_nvme_function_unpartitioned".
2. NVMe test case fixes for disc controller type NVMe.
3. "Nvme.verify_nvme_fstrim" - use fstrim testfile size based on available space.
4. Resource disc testcases fixes for VMs with Local NVMEs.
5. Added below new methods:
    a. check_resource_disk_mounted
    b. get_resource_disks
    c. get_resource_disk_type
    d. get_disk_type
    e. _remove_nvme_os_disk
    f. _get_os_disk_nvme_device
    g. _verify_nvme_function
@SRIKKANTH SRIKKANTH force-pushed the smyakam/nvme_test_fixes_15_09_2024 branch from 26b336a to 1d4da4f Compare November 23, 2024 12:39
@squirrelsc
Copy link
Member

@LiliDeng LGTM

@LiliDeng LiliDeng merged commit 630122e into main Nov 25, 2024
45 checks passed
@LiliDeng LiliDeng deleted the smyakam/nvme_test_fixes_15_09_2024 branch November 25, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants