Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cybereason driver query return instance name in dataframe #804

Merged
merged 8 commits into from
Nov 23, 2024
Merged

Cybereason driver query return instance name in dataframe #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
49c07b6
Add max retry parameter to the execution
Oct 18, 2024
f994e75
Merge branch 'main' into cybereason-driver-fix-http429
ianhelle Oct 21, 2024
1c34e06
Merge branch 'main' into cybereason-driver-fix-http429
ianhelle Oct 21, 2024
8c72783
Add tests and raise exception after max retry
Oct 22, 2024
6e453dc
doc and keyword params
Oct 22, 2024
f21438d
return cybereason instance name in dataframe
Oct 22, 2024
041c072
Merge branch 'main' of https://github.com/vx3r/msticpy into cybereaso…
Nov 21, 2024
99144a5
Merge branch 'main' into cybereason-driver-query-return-instance
ianhelle Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msticpy/data/drivers/cybereason_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def query(
)
else:
df_result = self._format_result_to_dataframe(result=response)

df_result["instance"] = self.instance
return df_result

def _exec_paginated_queries(
Expand Down
1 change: 1 addition & 0 deletions tests/data/drivers/test_cybereason_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def test_query(driver):
check.is_true(connect.called or driver.connected)
check.is_true(query.called)
check.is_instance(data, pd.DataFrame)
check.is_true("instance" in data.columns)

@respx.mock
def test_partial_success_query(driver):
Expand Down