Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTestFrameworkPkg\UnitTestFrameworkPkg.dec: Reenable access to PrivateInclude. #1060

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jul 23, 2024

Description

mu_plus DxeMemoryProtectionApp and XmlSupportPkg's UnitTestResultReportJUnitFormatLib\UnitTestResultReportLib.inf both make use of internals of the UnitTestFrameworkPkg's PrivateIncludes folder.

Temporarily adding back the PrivateIncludes folder while those others are examined to try to remove the dependecy.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Local CI on mu_plus repo using 202405 branches.

Integration Instructions

N/A

@apop5
Copy link
Contributor Author

apop5 commented Jul 23, 2024

Tracking removal microsoft/mu_plus#529

@os-d os-d requested review from makubacki and kuqin12 July 23, 2024 21:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@7f6831e). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405    #1060   +/-   ##
=================================================
  Coverage                  ?    1.51%           
=================================================
  Files                     ?     1436           
  Lines                     ?   359840           
  Branches                  ?     5355           
=================================================
  Hits                      ?     5458           
  Misses                    ?   354285           
  Partials                  ?       97           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (?)
MdePkg 5.41% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 merged commit 5bfab09 into microsoft:release/202405 Jul 24, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants