impr(optimization): Optimized dockerfile, reduced image size. (@Ilolm) #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilolm
commented
Oct 28, 2024
ilolm
commented
- Reduced layers.
- Enhanced readability.
- Reduced image size from 3.52GB to 3.41GB.
|
The docker file is synced from .sync/containers/Ubuntu-22/Dockerfile Changes should be made in that file, and when filesync runs, it would be filtered to this location. |
|
This looks fine to me. The changes to Containers/Ubuntu-22 should be dropped from the PR. After this PR is merged, a filesync (https://github.com/microsoft/mu_devops/blob/main/.github/workflows/FileSyncer.yml) will be run, and it will propagate the changes into the Containers/Ubuntu-22 file through that mechanism. When the file sync runs, it will overwrite the direct changes you are suggesting in Containers/Ubuntu-22 file. |
apop5
reviewed
Nov 5, 2024
Closes microsoft#372 This new workflow will attempt to automatically cherry-pick marked contributions to a development branch to its corresponding release branch. If a merge conflict occurs, the commit is committed to a new branch with merge markers and then a PR is created into the target branch with those markers. The PR is labeled with `type:release-merge-conflict` to indicate that it needs manual resolution. The PR (if created) is expected to fail compilation and status checks of course due to the merge conflict markers. A human should then checkout the PR branch, resolve the conflicts, and push the changes back to the PR branch. --- - To mark a PR going into the development branch so that it should be cherry-picked to the release branch, add the `type:backport` label to the PR. --- Notes: - The workflow is synced to all repos that currently have a `dev` branch. - Each repo that `backport-to-release-branch.yml` is synced to must have a `CHERRY_PICK_TOKEN` defined with repo write permission. Signed-off-by: Michael Kubacki <[email protected]>
apop5
approved these changes
Nov 5, 2024
Javagedes
reviewed
Nov 6, 2024
Javagedes
reviewed
Nov 6, 2024
|
@Javagedes Appreciate your notice, thanks for review <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.