-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the platform libraries and add platform initialization routine #16
Conversation
cfernald
commented
Sep 13, 2022
•
edited
Loading
edited
- Merge the platform specific libraries into a single library
- Introduce PlatformIpmiInitialize to allow platform specific initialization logic
- Clean up the generic IPMI PEIM & SMM module
- Remove the unused context pointer from within generic IPMI
IpmiFeaturePkg/Library/IpmiPlatformLibNull/IpmiPlatformLibNull.c
Outdated
Show resolved
Hide resolved
There is still the possibility that both Dxe and Smm can run the initialization code, when Pei gIpmiBmcHobGuid is not available. Given that this is a possibility, in platforms that do not have a traditional Pei phase, should we consider something to address that in the future? |
This is something I considered, but didn't have a clear idea on how to solve this potential issue. I created issue #17 for this to keep track of this though. |