Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the platform libraries and add platform initialization routine #16

Merged
merged 11 commits into from
Sep 14, 2022

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Sep 13, 2022

  • Merge the platform specific libraries into a single library
  • Introduce PlatformIpmiInitialize to allow platform specific initialization logic
  • Clean up the generic IPMI PEIM & SMM module
  • Remove the unused context pointer from within generic IPMI

@cfernald cfernald requested a review from apop5 September 13, 2022 16:46
IpmiFeaturePkg/GenericIpmi/Common/GenericIpmi.h Outdated Show resolved Hide resolved
IpmiFeaturePkg/GenericIpmi/Common/GenericIpmi.h Outdated Show resolved Hide resolved
IpmiFeaturePkg/Include/Library/IpmiPlatformLib.h Outdated Show resolved Hide resolved
@apop5
Copy link
Contributor

apop5 commented Sep 14, 2022

There is still the possibility that both Dxe and Smm can run the initialization code, when Pei gIpmiBmcHobGuid is not available.

Given that this is a possibility, in platforms that do not have a traditional Pei phase, should we consider something to address that in the future?

@apop5 apop5 closed this Sep 14, 2022
@apop5 apop5 reopened this Sep 14, 2022
@cfernald
Copy link
Contributor Author

There is still the possibility that both Dxe and Smm can run the initialization code, when Pei gIpmiBmcHobGuid is not available.

Given that this is a possibility, in platforms that do not have a traditional Pei phase, should we consider something to address that in the future?

This is something I considered, but didn't have a clear idea on how to solve this potential issue. I created issue #17 for this to keep track of this though.

@cfernald cfernald added the type:enhancement New feature or pull request label Sep 14, 2022
@cfernald cfernald merged commit d13a0aa into microsoft:main Sep 14, 2022
@cfernald cfernald deleted the platform_libs branch September 14, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants