Fix ETW trace logging crash in multithreading situations (#21566) #21603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETW trace logger is fakely registered as initialized_ is marked as true before the registration is done, causing crashing issue for Lenovo camera application. A prior attempt to address was made here: #21226 It was reverted here: #21360 The problem is that during initialization of TraceLoggingRegisterEx, it will reinvoke the callback and attempt reinitialization, which is not allowed. TraceLoggingRegisterEx however can be initialized concurrently when initialization happens on multiple threads. For these reasons it needs to be protected by a lock, but the lock cannot naively block because the callback's reinvocation will cause a deadlock. To solve this problem another tracking variable is added : "initializing" which protects against reinitialization during the first initialization. --------- Co-authored-by: Sheil Kumar <[email protected]>
smk2007
requested review from
fdwr,
PatriceVignola,
zhangxiang1993 and
martinb35
zhangxiang1993
previously approved these changes
Aug 6, 2024
fdwr
approved these changes
Aug 8, 2024
zhangxiang1993
previously approved these changes
Aug 8, 2024
yf711
previously approved these changes
Aug 8, 2024
fdwr
previously approved these changes
Aug 8, 2024
Xiang: I'm unsure who you need for this 🤔. Yifan Li and my approval are obviously inadequate. |
baijumeswani
previously approved these changes
Aug 8, 2024
zhangxiang1993
dismissed stale reviews from baijumeswani, fdwr, yf711, and themself
via
e7d1be0
snnn
approved these changes
Aug 8, 2024
fdwr
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETW trace logger is fakely registered as initialized_ is marked as true before the registration is done, causing crashing issue for Lenovo camera application.
A prior attempt to address was made here:
#21226 It was reverted here:
#21360
The problem is that during initialization of TraceLoggingRegisterEx, it will reinvoke the callback and attempt reinitialization, which is not allowed. TraceLoggingRegisterEx however can be initialized concurrently when initialization happens on multiple threads. For these reasons it needs to be protected by a lock, but the lock cannot naively block because the callback's reinvocation will cause a deadlock.
To solve this problem another tracking variable is added : "initializing" which protects against reinitialization during the first initialization.
Description
A few CI pipelines are disabled because they are no longer compatible with this legacy GE branch.
Motivation and Context