Skip to content

Commit

Permalink
chore(roll): roll Playwright to 1.45.0-beta-1719505820000 (#2951)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt authored Jul 1, 2024
1 parent f6b5ef7 commit 880775a
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 39 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->127.0.6533.5<!-- GEN:stop --> ||||
| Chromium <!-- GEN:chromium-version -->127.0.6533.17<!-- GEN:stop --> ||||
| WebKit <!-- GEN:webkit-version -->17.4<!-- GEN:stop --> ||||
| Firefox <!-- GEN:firefox-version -->127.0<!-- GEN:stop --> ||||

Expand Down
2 changes: 1 addition & 1 deletion src/Common/Version.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<AssemblyVersion>1.45.0</AssemblyVersion>
<PackageVersion>$(AssemblyVersion)</PackageVersion>
<DriverVersion>1.45.0-beta-1718782041000</DriverVersion>
<DriverVersion>1.45.0-beta-1719505820000</DriverVersion>
<ReleaseVersion>$(AssemblyVersion)</ReleaseVersion>
<FileVersion>$(AssemblyVersion)</FileVersion>
<NoDefaultExcludes>true</NoDefaultExcludes>
Expand Down
20 changes: 0 additions & 20 deletions src/Playwright/API/Generated/IBrowserContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -350,26 +350,6 @@ public partial interface IBrowserContext
/// "&lt;div&gt;&lt;/div&gt;");<br/>
/// await page.GetByRole(AriaRole.Button).ClickAsync();
/// </code>
/// <para>An example of passing an element handle:</para>
/// <code>
/// var result = new TaskCompletionSource&lt;string&gt;();<br/>
/// var page = await Context.NewPageAsync();<br/>
/// await Context.ExposeBindingAsync("clicked", async (BindingSource _, IJSHandle t) =&gt;<br/>
/// {<br/>
/// return result.TrySetResult(await t.AsElement().TextContentAsync());<br/>
/// });<br/>
/// <br/>
/// await page.SetContentAsync("&lt;script&gt;\n" +<br/>
/// " document.addEventListener('click', event =&gt; window.clicked(event.target));\n" +<br/>
/// "&lt;/script&gt;\n" +<br/>
/// "&lt;div&gt;Click me&lt;/div&gt;\n" +<br/>
/// "&lt;div&gt;Or click me&lt;/div&gt;\n");<br/>
/// <br/>
/// await page.ClickAsync("div");<br/>
/// // Note: it makes sense to await the result here, because otherwise, the context<br/>
/// // gets closed and the binding function will throw an exception.<br/>
/// Assert.AreEqual("Click me", await result.Task);
/// </code>
/// </summary>
/// <param name="name">Name of the function on the window object.</param>
/// <param name="callback">Callback function that will be called in the Playwright's context.</param>
Expand Down
17 changes: 0 additions & 17 deletions src/Playwright/API/Generated/IPage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -794,23 +794,6 @@ public partial interface IPage
/// }<br/>
/// }
/// </code>
/// <para>An example of passing an element handle:</para>
/// <code>
/// var result = new TaskCompletionSource&lt;string&gt;();<br/>
/// await page.ExposeBindingAsync("clicked", async (BindingSource _, IJSHandle t) =&gt;<br/>
/// {<br/>
/// return result.TrySetResult(await t.AsElement().TextContentAsync());<br/>
/// });<br/>
/// <br/>
/// await page.SetContentAsync("&lt;script&gt;\n" +<br/>
/// " document.addEventListener('click', event =&gt; window.clicked(event.target));\n" +<br/>
/// "&lt;/script&gt;\n" +<br/>
/// "&lt;div&gt;Click me&lt;/div&gt;\n" +<br/>
/// "&lt;div&gt;Or click me&lt;/div&gt;\n");<br/>
/// <br/>
/// await page.ClickAsync("div");<br/>
/// Console.WriteLine(await result.Task);
/// </code>
/// </summary>
/// <remarks><para>Functions installed via <see cref="IPage.ExposeBindingAsync"/> survive navigations.</para></remarks>
/// <param name="name">Name of the function on the window object.</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@ public BrowserContextExposeBindingOptions(BrowserContextExposeBindingOptions clo
}

/// <summary>
/// <para>**DEPRECATED** This option will be removed in the future.</para>
/// <para>
/// Whether to pass the argument as a handle, instead of passing by value. When passing
/// a handle, only one argument is supported. When passing by value, multiple arguments
/// are supported.
/// </para>
/// </summary>
[JsonPropertyName("handle")]
[System.Obsolete]
public bool? Handle { get; set; }
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@ public PageExposeBindingOptions(PageExposeBindingOptions clone)
}

/// <summary>
/// <para>**DEPRECATED** This option will be removed in the future.</para>
/// <para>
/// Whether to pass the argument as a handle, instead of passing by value. When passing
/// a handle, only one argument is supported. When passing by value, multiple arguments
/// are supported.
/// </para>
/// </summary>
[JsonPropertyName("handle")]
[System.Obsolete]
public bool? Handle { get; set; }
}

Expand Down
2 changes: 2 additions & 0 deletions src/Playwright/Core/BrowserContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,9 @@ public async Task<IReadOnlyList<BrowserContextCookiesResult>> CookiesAsync(IEnum

[MethodImpl(MethodImplOptions.NoInlining)]
public Task ExposeBindingAsync(string name, Action callback, BrowserContextExposeBindingOptions options = default)
#pragma warning disable CS0612 // Type or member is obsolete
=> ExposeBindingAsync(name, callback, handle: options?.Handle ?? false);
#pragma warning restore CS0612 // Type or member is obsolete

[MethodImpl(MethodImplOptions.NoInlining)]
public Task ExposeBindingAsync(string name, Action<BindingSource> callback)
Expand Down
2 changes: 2 additions & 0 deletions src/Playwright/Core/Page.cs
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,9 @@ public async Task<IResponse> ReloadAsync(PageReloadOptions options = default)

[MethodImpl(MethodImplOptions.NoInlining)]
public Task ExposeBindingAsync(string name, Action callback, PageExposeBindingOptions options = default)
#pragma warning disable CS0612 // Type or member is obsolete
=> InnerExposeBindingAsync(name, (Delegate)callback, options?.Handle ?? false);
#pragma warning restore CS0612 // Type or member is obsolete

[MethodImpl(MethodImplOptions.NoInlining)]
public Task ExposeBindingAsync(string name, Action<BindingSource> callback)
Expand Down

0 comments on commit 880775a

Please sign in to comment.