-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prompty: improve token count estimation #3821
Open
ianchi
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
ianchi:tokens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tools definitions and tool calls into the computation
This is needed for AzureOpenAI models where the deployment name is not a valid OpenAI model.
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
github-actions
bot
added
the
no-recent-activity
There has been no recent activity on this issue/pull request
label
Nov 2, 2024
Hi, any chance to advance with this? |
github-actions
bot
removed
the
no-recent-activity
There has been no recent activity on this issue/pull request
label
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current token count estimation is incomplete.
This PR adds tools definitions and tool calls into the computation, and allows to define a valid OpenAI model name to use to determine the tokenizer, which is needed in case of Azure OpenAI when the deployment is not a valid OpenAI model name.
Fixes #3809.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines