Enable searching through a view's parents for a React tag to call blur/focus on #2325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow-up to #2323. I found that the first responder may not necessarily have a React tag (e.g., a
<TextInput>
, as explained in the code's comments). To fix this, we just crawl up the view hierarchy to find the first ancestor that has a React tag and dispatch the relevant event there.Test Plan:
The test app made for #2323 has been updated to include a
<TextInput>
, and I validated that blur and focus events still come through as before.The base for the test app can be found here, although you'll have to add the changes to RCTRootView.m manually.