Skip to content

Commit

Permalink
Python: Support numpy >=1.25.0 for SK Python versions < '3.12' (#8819)
Browse files Browse the repository at this point in the history
### Motivation and Context

In our pyproject.toml configuration we had different version of numpy
support based on which version of Python one uses. Since Python 3.10 is
supported with numpy 1.26.0, and Python 3.10 is the lowest Python
version we support, we can move to support numpy 1.26.0 and further
updates.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

This PR updates to solely use numpy 1.26.0 for all SK Python versions.
It also updates the uv.lock file.
- Fixes #8673 

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
  • Loading branch information
moonbox3 authored Sep 16, 2024
1 parent e9f1fca commit 75c21ca
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 102 deletions.
4 changes: 2 additions & 2 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ dependencies = [
"defusedxml ~= 0.7",

# embeddings
"numpy ~= 1.25.0; python_version < '3.12'",
"numpy ~= 1.26.0; python_version >= '3.12'",
"numpy >= 1.25.0; python_version < '3.12'",
"numpy >= 1.26.0; python_version >= '3.12'",

# openai connector
"openai ~= 1.0",
Expand Down
Loading

0 comments on commit 75c21ca

Please sign in to comment.