Add materialized views support in Kusto Service Layer #2028
Conversation
Implements support for materialized views in Kusto Service Layer.
|
@microsoft-github-policy-service agree |
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
This reverts commit 71ab1be.
|
Reverted package updates as they caused multiple unforeseen issues. The only tradeoff I can see is that materialized view symbols are shown as "Table" in autocomplete widgets. Package update comments are therefore no longer applicable. |
| SetTableMetadata(databaseMetadata, tableInfos, rootTableFolderKey.ToString()); | ||
| } | ||
|
|
||
| private IEnumerable<TableInfo> GetMaterializedViewsInfos(string databaseName) | ||
| { | ||
| CancellationTokenSource source = new CancellationTokenSource(); |
There was a problem hiding this comment.
In other variables you start with var, couldn't these two be started with var too?
var source = new CancellationTokenSource();
var token = source.Token;
| { | ||
| ValidationUtils.IsNotNullOrWhitespace(databaseName, nameof(databaseName)); | ||
|
|
||
| CancellationTokenSource source = new CancellationTokenSource(); |
There was a problem hiding this comment.
In other variables you start with var, couldn't these two be started with var too?
var source = new CancellationTokenSource();
var token = source.Token;
| @@ -193,7 +195,7 @@ private void GenerateNodePath() | |||
| return false; | |||
| } | |||
| // Otherwise add this value to the beginning of the path and keep iterating up | |||
| path = string.Format(CultureInfo.InvariantCulture, | |||
| path = string.Format(CultureInfo.InvariantCulture, | |||
| "{0}{1}{2}", node.NodePathName, string.IsNullOrEmpty(path) ? "" : PathPartSeperator.ToString(), path); | |||
|
Hello, any feedback on how to merge this will be appreciated 😄 This is a feature I have been highly anticipating to use in my daily usage of ADS! |
Addresses microsoft/azuredatastudio#21527.