Use --roll-forward Major flag to make .dll tool runtime agnostic
#4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
changed the title
--roll-forward Major flag to make .dll tool runtime agnostic
alexweininger
approved these changes
Nov 6, 2024
MicroFish91
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4311
Nathan Carlson clued us in on a flag that you can pass to make the
dotnettool major version agnostic. So I've used the .NET 6 .dll tools (which should be forward compatible with 7, 8, and 9) and got rid of all the other runtime specific .dlls.This is nice because we theoretically shouldn't have to update the JsonCliTool ever again.