Implement findDocumentSymbols2()
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsoncodehk
force-pushed
the
document-symbol
branch
from
3733e09 to
646aab0
Compare
johnsoncodehk
changed the title
DocumentSymbol[] for findDocumentSymbols()findDocumentSymbols2()
johnsoncodehk
changed the title
findDocumentSymbols2()findDocumentSymbols2()
aeschli
approved these changes
Sep 8, 2023
chrmarti
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look to https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_documentSymbol,
DocumentSymbolis a better data structure. AddedfindDocumentSymbols2()API to returnDocumentSymbol[]and align withvscode-css-languageserviceandvscode-json-languageservice.Fix #130.