Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to determine if javaExec is specified in the #1123

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add check to determine if javaExec is specified in the #1123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00a5f26
Add check to determine if javaExec is specified in the
Rod-Christensen Feb 14, 2022
db9e676
Hopefully corrected lint error
Rod-Christensen Feb 15, 2022
9d6e8e1
Merge branch 'main' into javaExec
Rod-Christensen Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/configurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,12 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
});
}

config.javaExec = await lsPlugin.resolveJavaExecutable(config.mainClass, config.projectName);
// Add the default launch options to the config.
// If not provided in the launch config, resolve the java executable
if (!config.javaExec) {
config.javaExec = await lsPlugin.resolveJavaExecutable(config.mainClass, config.projectName);
}

// Add the default launch options to the config.
config.cwd = config.cwd || _.get(folder, "uri.fsPath");
if (Array.isArray(config.args)) {
config.args = this.concatArgs(config.args);
Expand Down