Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore disabled widget tests #16308

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Restore disabled widget tests #16308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
424e334
Restore disabled widget tests
DonJayamanne Dec 17, 2024
8319faf
Merge branch 'main' into restoreWidgetTests
DonJayamanne Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/test/datascience/widgets/standardWidgets.vscode.common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ suite('Standard IPyWidget Tests @widgets', function () {
// Also display the same nested output and the widget in the 3rd cell.
await Promise.all([runCell(cell3), waitForCellExecutionToComplete(cell3)]);
await assertOutputContainsHtml(cell1, comms, ['<input type="text'], '.widget-output');
// await assertOutputContainsHtml(cell1, comms, ['<input type="text', 'Label Widget'], '.widget-output');
await assertOutputContainsHtml(cell1, comms, ['<input type="text', 'Label Widget'], '.widget-output');
assert.strictEqual(cell3.outputs.length, 0, 'Cell 3 should not have any output');

// Run the 4th cell & verify we have output in the first nested output & second output.
Expand All @@ -343,11 +343,11 @@ suite('Standard IPyWidget Tests @widgets', function () {
);
assert.strictEqual(cell3.outputs.length, 0, 'Cell 3 should not have any output');

// // Verify both textbox widgets are linked.
// // I.e. updating one textbox will result in the other getting updated with the same value.
// await comms.setValue(cell1, '.widget-text input', 'Widgets are linked an get updated');
// await assertOutputContainsHtml(cell1, comms, ['>Widgets are linked an get updated<'], '.widget-output');
// assert.strictEqual(cell3.outputs.length, 0, 'Cell 3 should not have any output');
// Verify both textbox widgets are linked.
// I.e. updating one textbox will result in the other getting updated with the same value.
await comms.setValue(cell1, '.widget-text input', 'Widgets are linked an get updated');
await assertOutputContainsHtml(cell1, comms, ['>Widgets are linked an get updated<'], '.widget-output');
assert.strictEqual(cell3.outputs.length, 0, 'Cell 3 should not have any output');
});
test('More Nested Output Widgets', async () => {
await initializeNotebookForWidgetTest(
Expand Down
Loading