Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port provider #85

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Add port provider #85

merged 8 commits into from
Sep 18, 2023

Conversation

paulacamargo25
Copy link
Contributor

First part of the implementation of microsoft/vscode-python#21292

  • Register with the port forwarding API, and mark all ports as Ignore

@paulacamargo25 paulacamargo25 self-assigned this Sep 13, 2023
@paulacamargo25 paulacamargo25 added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Sep 13, 2023
@paulacamargo25 paulacamargo25 added this to the September 2023 milestone Sep 13, 2023
@paulacamargo25 paulacamargo25 marked this pull request as ready for review September 13, 2023 22:55
@karthiknadig
Copy link
Member

@int19h Can you take a look at this?

alexr00
alexr00 requested changes Sep 14, 2023
View reviewed changes
src/extension/debugger/debugPort/portAttributesProvider.ts Outdated Show resolved Hide resolved
src/extension/extensionInit.ts Outdated Show resolved Hide resolved
alexr00
alexr00 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as an initial, no-op, implementation!

@paulacamargo25 paulacamargo25 merged commit 5aaf0cc into main Sep 18, 2023
18 checks passed
@paulacamargo25 paulacamargo25 deleted the Add-portProvider branch September 18, 2023 16:36
@alexr00 alexr00 mentioned this pull request Sep 19, 2023
Closed
paulacamargo25 added a commit to paulacamargo25/vscode-python-debugger that referenced this pull request Oct 31, 2023
@paulacamargo25
Add port provider (microsoft#85)
117bc23 
* Add port attribute provider

* Add message

* Enabled proposed api

* Ignore all the ports

* Fix format

* fix pr comments

* Add regex for terminal command

* Add adapter to pattern
paulacamargo25 added a commit that referenced this pull request Jan 15, 2024
@paulacamargo25 @dependabot
@lramos15 @luabud @DonJayamanne
Update branch for debugpy 1.5.1 with last changes in main (#124)
aa64a98 
* update pre release (#71)

* Add port provider (#85)

* Add port attribute provider

* Add message

* Enabled proposed api

* Ignore all the ports

* Fix format

* fix pr comments

* Add regex for terminal command

* Add adapter to pattern

* Add global configuration for justMyCode (#91)

* Aff configuration

* Read just my code from settings too

* fix tests

* fix lint

* Update extension name (#84)

* Update package.json

* Fix readme

* update debug type name

* Fix tests

* Fix lint

* Fix test

* Update translations

* revert extension id

* Fix tests

* fix lint

* Update debug type name

* Fix translations and lint

* update debug type

* fix lint

* use version 1.7 (#95)

* Remove default justMyCode (#100)

* Fix error in workspace (#101)

* Fix error in workspace

* fix test and lint

* Fix format

* Bump mheap/github-action-required-labels from 3 to 5 (#23)

Bumps [mheap/github-action-required-labels](https://github.com/mheap/github-action-required-labels) from 3 to 5.
- [Release notes](https://github.com/mheap/github-action-required-labels/releases)
- [Commits](mheap/github-action-required-labels@v3...v5)

---
updated-dependencies:
- dependency-name: mheap/github-action-required-labels
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @typescript-eslint/parser from 5.59.11 to 5.62.0 (#61)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.11 to 5.62.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.62.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump typescript from 5.1.3 to 5.2.2 (#79)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.3 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.1.3...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update npm packages (#105)

* update package.json

* Fux lint

* Update to node 18 (#106)

* Platform-specific vsix (#89)

* Update nox file and pre release

* update args

* update value

* see params

* echo vars

* fix args

* fix args

* Fix error obj to string

* fix command line error

* update args

* update how access values

* Add args

* Send arguments

* tried ith arguments

* update value

* remove args extra

* update run

* send as env

* add to see other values

* update env variables

* use VSCETARGET

* fix variable

* Fix macOs error

* Fix lint in nox file

* Fix nox hash comparison

* Fix default value

* Remove unnecessary code

* Update platform url and debugpy version

* Fix dict key name

* Remove vsix for all platforms

* Fix pr comments

* fix download function

* fix hash code

* Read from json pypypackage

* add json file and session that creates it

* Reformat nox file

* resolve comments

* fix lint error

* update pipeline

* fix build error

* dont hardcode the hash

* Fix GDPR comments (#113)

* Update readme (#111)

* Update readme

* Update README.md

Co-authored-by: Luciana Abud <[email protected]>

---------

Co-authored-by: Luciana Abud <[email protected]>

* Remove build folder from bundled vsix (#120)

* Update debugpy version

* Update nox and  pipelines

* update json file

* fix actions

* fix 3.6 error

* fix error running with 3.6

* fix lint

* update python version

* fix error in lint pipeline

* update pipelines

* fix nox file

* fix tests

* fix pipeline error

* fix lint

* use python 3.6

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Logan Ramos <[email protected]>
Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Don Jayamanne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexr00 alexr00 alexr00 approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

@paulacamargo25 paulacamargo25

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@paulacamargo25 @karthiknadig @alexr00