fix tests

microsoft · Feb 5, 2024 · 6b8f19f · 6b8f19f
1 parent 9feabf9
commit 6b8f19f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/client/pythonEnvironments/base/locatorUtils.ts b/src/client/pythonEnvironments/base/locatorUtils.ts
@@ -95,6 +95,8 @@ export async function getEnvs<I = PythonEnvInfo>(iterator: IPythonEnvsIterator<I
                 }
                 // We don't worry about if envs[index] is set already.
                 envs[index] = update;
+            } else if (event.update) {
+                envs.push(event.update);
             }
         });
     }

diff --git a/src/client/pythonEnvironments/base/locators/lowLevel/windowsRegistryLocator.ts b/src/client/pythonEnvironments/base/locators/lowLevel/windowsRegistryLocator.ts
@@ -10,6 +10,7 @@ import {
     IPythonEnvsIterator,
     Locator,
     ProgressNotificationEvent,
+    ProgressReportStage,
     PythonEnvUpdatedEvent,
 } from '../../locator';
 import { getRegistryInterpreters } from '../../../common/windowsUtils';
@@ -66,6 +67,7 @@ async function updateLazily(didUpdate: EventEmitter<PythonEnvUpdatedEvent<BasicE
             traceError(`Failed to process environment: ${interpreter}`, ex);
         }
     }
+    didUpdate.fire({ stage: ProgressReportStage.discoveryFinished });
     traceVerbose('Finished searching for windows registry interpreters');
 }
 

diff --git a/src/test/pythonEnvironments/base/locators/lowLevel/windowsRegistryLocator.unit.test.ts b/src/test/pythonEnvironments/base/locators/lowLevel/windowsRegistryLocator.unit.test.ts
@@ -222,7 +222,7 @@ suite('Windows Registry', () => {
             createBasicEnv(PythonEnvKind.OtherGlobal, path.join(regTestRoot, 'python38', 'python.exe')),
         ].map((e) => ({ ...e, source: [PythonEnvSource.WindowsRegistry] }));
 
-        const iterator = locator.iterEnvs(undefined, false);
+        const iterator = locator.iterEnvs(undefined, true);
         const actualEnvs = await getEnvs(iterator);
 
         assertBasicEnvsEqual(actualEnvs, expectedEnvs);
@@ -233,7 +233,7 @@ suite('Windows Registry', () => {
             throw Error();
         });
 
-        const iterator = locator.iterEnvs();
+        const iterator = locator.iterEnvs(undefined, true);
         const actualEnvs = await getEnvs(iterator);
 
         assert.deepStrictEqual(actualEnvs, []);
@@ -252,7 +252,7 @@ suite('Windows Registry', () => {
             createBasicEnv(PythonEnvKind.OtherGlobal, path.join(regTestRoot, 'python38', 'python.exe')),
         ].map((e) => ({ ...e, source: [PythonEnvSource.WindowsRegistry] }));
 
-        const iterator = locator.iterEnvs();
+        const iterator = locator.iterEnvs(undefined, true);
         const actualEnvs = await getEnvs(iterator);
 
         assertBasicEnvsEqual(actualEnvs, expectedEnvs);