Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dev container node version to 18 #21949

Closed
wants to merge 1 commit into from
Closed

Upgrade dev container node version to 18 #21949

wants to merge 1 commit into from

Conversation

anthonykim1
Copy link

Following: #21937, to update node version in dev container to be 18 from 16.

@anthonykim1 anthonykim1 added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Sep 7, 2023
@anthonykim1 anthonykim1 self-assigned this Sep 7, 2023
@anthonykim1 anthonykim1 mentioned this pull request Sep 7, 2023
Closed
@anthonykim1 anthonykim1 changed the title Upgrade dev container node version Upgrade dev container node version to 18 Sep 7, 2023
karrtikr
karrtikr approved these changes Sep 7, 2023
View reviewed changes
Copy link

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Make sure to merge it only after #21937 is merged. Alternatively you can also contribute to the PR branch in #21937.

@karrtikr karrtikr marked this pull request as draft September 7, 2023 22:55
@anthonykim1
Copy link
Author

Moved commits to: #21937 as advised. Thanks!

@anthonykim1 anthonykim1 closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

@anthonykim1 anthonykim1

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonykim1 @karrtikr