-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate extension to node 18 #21937
Migrate extension to node 18 #21937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to reproduce this issue locally? Try running npm run compile
inside the pythonExtensionApi
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compile passes
I assume this was run inside the api directory.
Can we also upgrade the node used by devcontainers/codespaces? cc/ @anthonykim1
Yes! That should be totally possible @karrtikr |
Yes it was run in the API directory. |
@karthiknadig Error is coming from a package https://www.npmjs.com/package/gulp-typescript which hasn't been updated in 4 years, so likely isn't adaptive to Node18. Is there a way to make the package use our "source-map" dependency instead of its own |
Can we just drop gulp? Use nox as task runner. |
@karthiknadig #21937 (comment) should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also create/link an issue corresponding to this PR.
We might need to update the test runner. Seems to be failing on windows |
@karthiknadig I think we can move everything over to nox. See here for implementation of |
Did not have permission to rebase and force push on this branch hence created a new PR: #22135. |
No description provided.