Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use worker threads for launching conda and windows registry when discovering #22146

Closed
karrtikr opened this issue Oct 3, 2023 · 36 comments · Fixed by #22964
Closed

Use worker threads for launching conda and windows registry when discovering #22146

karrtikr opened this issue Oct 3, 2023 · 36 comments · Fixed by #22964
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link

karrtikr commented Oct 3, 2023

#21755

Spike results

Based on CPU profiles in #21755 (comment) discovery is mainly blocked by:

  • Launching conda binary
  • Launching REG binary for windows registry
  • Windows Path discovery

Note spawning python binaries is fine, it blocks very little of the time.

@karrtikr karrtikr added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Oct 3, 2023
@karrtikr karrtikr self-assigned this Oct 3, 2023
@karrtikr karrtikr added this to the October 2023 milestone Oct 3, 2023
@karrtikr karrtikr modified the milestones: October 2023, November 2023 Oct 23, 2023
@karrtikr karrtikr changed the title Use webworker for launching conda and windows registry when discovering Use worker threads for launching conda and windows registry when discovering Nov 15, 2023
@Tyriar
Copy link
Member

Tyriar commented Nov 15, 2023

@deepak1556 do you know why spawn would be blocking the thread for so long here?

image

Profiles at #21755 (comment)

@karrtikr
Copy link
Author

Note this is when spawning the conda binary, similarly spawning REG binaries can seldomly be like this. But python binaries are much cheaper for some reason.

@karrtikr
Copy link
Author

It's not just us, the git extension while spawning also runs into this:

image

@DonJayamanne
Copy link

DonJayamanne commented Nov 16, 2023

do you know why spawn would be blocking the thread for so long here?

This was my observation a few years ago as well ( #15813 (comment))
Back then I reached out to jrieken , and he indicated that in node, spawning processes can block the main thread for a few ms.
However we didn't try to dig further into why spawning conda was blocking for a few seconds, primarily because the suggestion was not being actively worked on back then

@karrtikr
Copy link
Author

Performance issue filled for other cases here: microsoft/vscode#198384

@Tyriar
Copy link
Member

Tyriar commented Nov 16, 2023

Yeah a few ms is expected, but it's very different from over 2 seconds which is what the first spawn takes in my screenshot.

@deepak1556
Copy link

@Tyriar not sure but having some basic data points from @karrtikr I feel there is a binary scanning delaying the spawn call. @karrtikr can you collect an event trace following the steps below.

  • Open Windows Performance Recorder from system start menu
  • Have the following settings

Screenshot 2022-08-23 200440

  • Start the recorder
  • Open the application
  • Perform the steps for slow spawn call, stop the recorder and save the profile
  • Send the profile to [email protected] instead of attaching to this issue, since it will contain sensitive information.

@karrtikr
Copy link
Author

I've shared the event trace via email.

@deepak1556
Copy link

@karrtikr thanks for the trace, I looked into it and found it to be unusual, the uv_spawn (equivalent of child_process.spawn) call in question shows a wait time of 2.7s but the interesting bit is that wait is on the thread performing v8 cpu profiling, not what I had expected.
uv_spawn_sample_delay

Can you provide me another windows event trace of the slow conda or win reg or git spawn calls but this time don't invoke the v8 cpu profiler. I am curious to see how the trace comes out without any node inspector involved.

@DonJayamanne

This comment was marked as off-topic.

@deepak1556
Copy link

deepak1556 commented Nov 22, 2023

Issue is unrelated to the node.js issue, it is specific to fork syscall on linux impacted with v8 heap regions which is already fixed in upstream and also fixed in our stable versions for a while now. I haven't seen similar issues for windows and the current data is still too early to conclude.

@rzhao271 rzhao271 removed verified Verification succeeded verification-needed Verification of issue is requested verification-found Issue verification failed labels Feb 23, 2024
@karrtikr
Copy link
Author

karrtikr commented Feb 26, 2024

@andreamah I've prepared a fix which very likely fixes the issue, please give it a try when you can: https://github.com/microsoft/vscode-python/actions/runs/8045205090/artifacts/1274325464. You can use Extension: Install from VSIX command to install it.

Make sure run Python: Clear cache and reload window command.

@karrtikr karrtikr added the verification-needed Verification of issue is requested label Feb 26, 2024
@karrtikr
Copy link
Author

@andreamah Fix should be out in the pre-release version of the extension.

anthonykim1 pushed a commit that referenced this issue Feb 29, 2024
Failing tests are due to
#22965, this can still
be reviewed.

Closes #22918 closes
#22146
karrtikr pushed a commit that referenced this issue Mar 14, 2024
@karrtikr
Copy link
Author

Verification steps: #22146 (comment)

@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2024

This failed verification for me, the output shows the worker option is active, but there's an exception launching conda (which I don't think is installed) and there's no "worker id":

2024-03-25 12:03:15.411 [info] Experiment 'pythonRecommendTensorboardExt' is active
2024-03-25 12:03:15.411 [info] Experiment 'pythonREPLSmartSend' is active
2024-03-25 12:03:15.411 [info] Experiment 'pythonTerminalEnvVarActivation' is active
2024-03-25 12:03:15.411 [info] Experiment 'pythonTestAdapter' is active
2024-03-25 12:03:15.411 [info] Default formatter is set to null for workspace /Users/tyriar/playground/hatch
2024-03-25 12:03:15.411 [info] Test server listening.
2024-03-25 12:03:15.411 [info] Python interpreter path: ~/Library/Application Support/hatch/env/virtual/testproj/7Y1g8kEb/testproj/bin/python
2024-03-25 12:03:16.023 [info] > . "~/Library/Application Support/hatch/env/virtual/testproj/7Y1g8kEb/testproj/bin/activate" && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/printEnvVariables.py
2024-03-25 12:03:16.023 [info] shell: bash
2024-03-25 12:03:16.129 [info] > /opt/homebrew/bin/python3.10 ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/printEnvVariables.py
2024-03-25 12:03:16.129 [info] shell: bash
2024-03-25 12:03:16.423 [info] Setting environment variable VIRTUAL_ENV in collection to /Users/tyriar/Library/Application Support/hatch/env/virtual/testproj/7Y1g8kEb/testproj {"applyAtShellIntegration":true,"applyAtProcessCreation":true}
2024-03-25 12:03:16.423 [info] Prepending environment variable PATH in collection with /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/deactivate/bash:/Users/tyriar/Library/Application Support/hatch/env/virtual/testproj/7Y1g8kEb/testproj/bin: {"applyAtShellIntegration":true,"applyAtProcessCreation":true}
2024-03-25 12:03:16.423 [info] Prepending environment variable PS1 in collection with (testproj)  {"applyAtShellIntegration":true,"applyAtProcessCreation":false}
2024-03-25 12:03:16.423 [info] Setting environment variable XPC_SERVICE_NAME in collection to 0 {"applyAtShellIntegration":true,"applyAtProcessCreation":true}
2024-03-25 12:03:16.423 [info] Setting environment variable VIRTUAL_ENV_PROMPT in collection to testproj {"applyAtShellIntegration":true,"applyAtProcessCreation":true}
2024-03-25 12:03:16.424 [info] Send text to terminal: /opt/homebrew/bin/python3.10 /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/printEnvVariablesToFile.py /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/deactivate/bash/envVars.txt
2024-03-25 12:03:17.139 [info] Starting Pylance language server.
2024-03-25 12:03:26.163 [info] Discover tests for workspace name: undefined - uri: /Users/tyriar/Library/Application Support/Code - Insiders/User/settings.json
2024-03-25 12:04:12.023 [info] Experiment 'pythonDiscoveryUsingWorkers' is active
2024-03-25 12:04:12.023 [info] Experiment 'pythonRecommendTensorboardExt' is active
2024-03-25 12:04:12.023 [info] Experiment 'pythonREPLSmartSend' is active
2024-03-25 12:04:12.023 [info] Experiment 'pythonTerminalEnvVarActivation' is active
2024-03-25 12:04:12.023 [info] Experiment 'pythonTestAdapter' is active
2024-03-25 12:04:12.023 [debug] Start watching file for changes /Users/tyriar/.conda/environments.txt
2024-03-25 12:04:12.023 [debug] Start watching: /Users/tyriar/.conda with pattern environments.txt using VSCode API
2024-03-25 12:04:12.023 [debug] Start watching root /Users/tyriar/playground/hatch for globs ["python","*/python","*/bin/python"]
2024-03-25 12:04:12.023 [debug] Start watching: /Users/tyriar/playground/hatch with pattern python using VSCode API
2024-03-25 12:04:12.023 [debug] Start watching: /Users/tyriar/playground/hatch with pattern */python using VSCode API
2024-03-25 12:04:12.023 [debug] Start watching: /Users/tyriar/playground/hatch with pattern */bin/python using VSCode API
2024-03-25 12:04:12.023 [info] Default formatter is set to null for workspace /Users/tyriar/playground/hatch
2024-03-25 12:04:12.023 [debug] Waiting for test server to start...
2024-03-25 12:04:12.023 [debug] Searching for interpreters in posix paths locator
2024-03-25 12:04:12.023 [debug] Searching for pyenv environments
2024-03-25 12:04:12.023 [debug] Searching for conda.
2024-03-25 12:04:12.023 [debug] Probing conda binary: conda
2024-03-25 12:04:12.023 [debug] Searching for custom workspace envs
2024-03-25 12:04:12.023 [debug] Probing Hatch binary hatch
2024-03-25 12:04:12.023 [info] Test server listening.
2024-03-25 12:04:12.023 [debug] Test server started.
2024-03-25 12:04:12.023 [debug] Testing: Setting up watcher for /Users/tyriar/playground/hatch
2024-03-25 12:04:12.023 [debug] Finished searching for custom virtual envs
2024-03-25 12:04:12.023 [debug] Couldn't locate the state binary.
2024-03-25 12:04:12.023 [debug] Dump environment variables {
    "COMMAND_MODE": "unix2003",
    "HOME": "/Users/tyriar",
    "HOMEBREW_CELLAR": "/opt/homebrew/Cellar",
    "HOMEBREW_PREFIX": "/opt/homebrew",
    "HOMEBREW_REPOSITORY": "/opt/homebrew",
    "INFOPATH": "/opt/homebrew/share/info:",
    "LESS": "-R",
    "LOGNAME": "tyriar",
    "LSCOLORS": "Gxfxcxdxbxegedabagacad",
    "LS_COLORS": "di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43",
    "MANPATH": "/opt/homebrew/share/man::",
    "MallocNanoZone": "0",
    "OLDPWD": "/",
    "ORIGINAL_XDG_CURRENT_DESKTOP": "undefined",
    "PAGER": "less",
    "PWD": "/",
    "SHELL": "/bin/zsh",
    "SHLVL": "0",
    "SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.1Yc7IXFDGh/Listeners",
    "TMPDIR": "/var/folders/nk/960h1fp91k3gpt8_70qg5j0h0000gn/T/",
    "USER": "tyriar",
    "VSCODE_AMD_ENTRYPOINT": "vs/workbench/api/node/extensionHostProcess",
    "VSCODE_CODE_CACHE_PATH": "/Users/tyriar/Library/Application Support/Code - Insiders/CachedData/b0d975fc6370f15570c380f41015b1ca2cdcb791",
    "VSCODE_CRASH_REPORTER_PROCESS_TYPE": "extensionHost",
    "VSCODE_CWD": "/",
    "VSCODE_HANDLES_UNCAUGHT_ERRORS": "true",
    "VSCODE_IPC_HOOK": "/Users/tyriar/Library/Application Support/Code - Insiders/1.88-main.sock",
    "VSCODE_NLS_CONFIG": "{\"locale\":\"en\",\"osLocale\":\"en-au\",\"availableLanguages\":{},\"_languagePackSupport\":true}",
    "VSCODE_PID": "15475",
    "XPC_FLAGS": "0x0",
    "XPC_SERVICE_NAME": "application.com.microsoft.VSCodeInsiders.13688824.13688831",
    "ZSH": "/Users/tyriar/.oh-my-zsh",
    "_": "/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron",
    "__CFBundleIdentifier": "com.microsoft.VSCodeInsiders",
    "__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0xF",
    "ELECTRON_RUN_AS_NODE": "1",
    "VSCODE_L10N_BUNDLE_LOCATION": "",
    "PATH": "/Library/Frameworks/Python.framework/Versions/3.12/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin"
}
2024-03-25 12:04:12.023 [info] > conda info --json
2024-03-25 12:04:12.023 [debug] Failed to spawn conda binary conda [Error: spawn conda ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:284:19)
	at onErrorNT (node:internal/child_process:477:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:82:21)] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn conda',
  path: 'conda',
  spawnargs: [ 'info', '--json' ]
}
2024-03-25 12:04:12.023 [debug] Searching for workspace virtual envs in: /Users/tyriar/playground/hatch
2024-03-25 12:04:12.023 [debug] Dump environment variables {
    "COMMAND_MODE": "unix2003",
    "HOME": "/Users/tyriar",
    "HOMEBREW_CELLAR": "/opt/homebrew/Cellar",
    "HOMEBREW_PREFIX": "/opt/homebrew",
    "HOMEBREW_REPOSITORY": "/opt/homebrew",
    "INFOPATH": "/opt/homebrew/share/info:",
    "LESS": "-R",
    "LOGNAME": "tyriar",
    "LSCOLORS": "Gxfxcxdxbxegedabagacad",
    "LS_COLORS": "di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43",
    "MANPATH": "/opt/homebrew/share/man::",
    "MallocNanoZone": "0",
    "OLDPWD": "/",
    "ORIGINAL_XDG_CURRENT_DESKTOP": "undefined",
    "PAGER": "less",
    "PWD": "/",
    "SHELL": "/bin/zsh",
    "SHLVL": "0",
    "SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.1Yc7IXFDGh/Listeners",
    "TMPDIR": "/var/folders/nk/960h1fp91k3gpt8_70qg5j0h0000gn/T/",
    "USER": "tyriar",
    "VSCODE_AMD_ENTRYPOINT": "vs/workbench/api/node/extensionHostProcess",
    "VSCODE_CODE_CACHE_PATH": "/Users/tyriar/Library/Application Support/Code - Insiders/CachedData/b0d975fc6370f15570c380f41015b1ca2cdcb791",
    "VSCODE_CRASH_REPORTER_PROCESS_TYPE": "extensionHost",
    "VSCODE_CWD": "/",
    "VSCODE_HANDLES_UNCAUGHT_ERRORS": "true",
    "VSCODE_IPC_HOOK": "/Users/tyriar/Library/Application Support/Code - Insiders/1.88-main.sock",
    "VSCODE_NLS_CONFIG": "{\"locale\":\"en\",\"osLocale\":\"en-au\",\"availableLanguages\":{},\"_languagePackSupport\":true}",
    "VSCODE_PID": "15475",
    "XPC_FLAGS": "0x0",
    "XPC_SERVICE_NAME": "application.com.microsoft.VSCodeInsiders.13688824.13688831",
    "ZSH": "/Users/tyriar/.oh-my-zsh",
    "_": "/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron",
    "__CFBundleIdentifier": "com.microsoft.VSCodeInsiders",
    "__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0xF",
    "ELECTRON_RUN_AS_NODE": "1",
    "VSCODE_L10N_BUNDLE_LOCATION": "",
    "PATH": "/Library/Frameworks/Python.framework/Versions/3.12/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin"
}
2024-03-25 12:04:12.023 [info] > hatch env show --json
2024-03-25 12:04:12.023 [info] cwd: .
2024-03-25 12:04:12.023 [debug] [Error: spawn hatch ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:284:19)
	at onErrorNT (node:internal/child_process:477:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:82:21)] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn hatch',
  path: 'hatch',
  spawnargs: [ 'env', 'show', '--json' ]
}
2024-03-25 12:04:12.023 [debug] Failed to find Hatch binary hatch
2024-03-25 12:04:12.023 [debug] No Hatch binary found
2024-03-25 12:04:12.023 [debug] Finished searching for Hatch envs
2024-03-25 12:04:12.026 [debug] Finished searching for global virtual envs
2024-03-25 12:04:12.026 [debug] Finished searching for workspace virtual envs
2024-03-25 12:04:12.033 [debug] Finished searching for poetry envs
2024-03-25 12:04:12.041 [debug] Attempting to resolve symbolic link: /usr/bin/python3
2024-03-25 12:04:12.042 [info] Found: /usr/bin/python3 --> /usr/bin/python3
2024-03-25 12:04:12.045 [debug] Couldn't locate the conda binary.
2024-03-25 12:04:12.045 [debug] Couldn't locate the conda binary.
2024-03-25 12:04:12.056 [debug] Attempting to resolve symbolic link: /usr/local/bin/python3
2024-03-25 12:04:12.056 [info] Found: /usr/local/bin/python3 --> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-25 12:04:12.056 [debug] Attempting to resolve symbolic link: /usr/local/bin/python3.12
2024-03-25 12:04:12.057 [info] Found: /usr/local/bin/python3.12 --> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-25 12:04:12.087 [debug] Attempting to resolve symbolic link: /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
2024-03-25 12:04:12.087 [info] Found: /Library/Frameworks/Python.framework/Versions/3.12/bin/python3 --> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-25 12:04:12.087 [debug] Attempting to resolve symbolic link: /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-25 12:04:12.087 [info] Found: /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12 --> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-25 12:04:12.087 [debug] Attempting to resolve symbolic link: /opt/homebrew/bin/python3.10
2024-03-25 12:04:12.088 [info] Found: /opt/homebrew/bin/python3.10 --> /opt/homebrew/Cellar/[email protected]/3.10.14/Frameworks/Python.framework/Versions/3.10/bin/python3.10
2024-03-25 12:04:12.088 [debug] Attempting to resolve symbolic link: /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.088 [info] Found: /opt/homebrew/bin/python3.11 --> /opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/bin/python3.11
2024-03-25 12:04:12.090 [debug] Found 4 python binaries in posix paths
2024-03-25 12:04:12.111 [debug] Python API env change detected /usr/bin/python3 add
2024-03-25 12:04:12.111 [info] > /usr/bin/python3 -I ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py
2024-03-25 12:04:12.113 [debug] Python API env change detected /usr/local/bin/python3 add
2024-03-25 12:04:12.113 [info] > /usr/local/bin/python3 -I ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py
2024-03-25 12:04:12.115 [debug] Python API env change detected /opt/homebrew/bin/python3.10 add
2024-03-25 12:04:12.115 [debug] Finished searching for interpreters in posix paths locator
2024-03-25 12:04:12.116 [debug] Python API env change detected /opt/homebrew/bin/python3.11 add
2024-03-25 12:04:12.116 [debug] Finished with environment reducer
2024-03-25 12:04:12.116 [debug] No cached env found for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.116 [debug] No cached env found for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.319 [debug] Received shell integration sequence for bash
2024-03-25 12:04:12.325 [debug] Found interpreter for >> /usr/local/bin/python3 -I /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py <<: {"versionInfo":[3,12,0,"final",0],"sysPrefix":"/Library/Frameworks/Python.framework/Versions/3.12","sysVersion":"3.12.0 (v3.12.0:0fb18b02c8, Oct  2 2023, 09:45:56) [Clang 13.0.0 (clang-1300.0.29.30)]","is64Bit":true}
2024-03-25 12:04:12.326 [info] > /opt/homebrew/bin/python3.10 -I ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py
2024-03-25 12:04:12.326 [debug] Python API env change detected /usr/local/bin/python3 update
2024-03-25 12:04:12.481 [debug] Found interpreter for >> /usr/bin/python3 -I /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py <<: {"versionInfo":[3,9,6,"final",0],"sysPrefix":"/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9","sysVersion":"3.9.6 (default, Feb  3 2024, 15:58:27) \n[Clang 15.0.0 (clang-1500.3.9.4)]","is64Bit":true}
2024-03-25 12:04:12.482 [info] > /opt/homebrew/bin/python3.11 -I ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py ~/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py
2024-03-25 12:04:12.482 [debug] Python API env change detected /usr/bin/python3 update
2024-03-25 12:04:12.482 [debug] Found interpreter for >> /opt/homebrew/bin/python3.10 -I /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py <<: {"versionInfo":[3,10,14,"final",0],"sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.10","sysVersion":"3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-1500.3.9.4)]","is64Bit":true}
2024-03-25 12:04:12.482 [debug] Python API env change detected /opt/homebrew/bin/python3.10 update
2024-03-25 12:04:12.652 [debug] Found interpreter for >> /opt/homebrew/bin/python3.11 -I /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/get_output_via_markers.py /Users/tyriar/.vscode-insiders/extensions/ms-python.python-2024.3.10851013/python_files/interpreterInfo.py <<: {"versionInfo":[3,11,8,"final",0],"sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.11","sysVersion":"3.11.8 (main, Feb  6 2024, 21:21:21) [Clang 15.0.0 (clang-1500.1.0.2.5)]","is64Bit":true}
2024-03-25 12:04:12.652 [debug] Python API env change detected /opt/homebrew/bin/python3.11 update
2024-03-25 12:04:12.652 [debug] Finished with environment resolver
2024-03-25 12:04:12.652 [debug] Environment resolver resolved /opt/homebrew/bin/python3.11 for {"name":"","location":"","kind":"global-other","executable":{"filename":"/opt/homebrew/bin/python3.11","sysPrefix":"","ctime":1710439746947,"mtime":1710439746947},"display":"Python 3.11.x","version":{"major":3,"minor":11,"micro":-1},"arch":1,"distro":{"org":""},"source":[],"id":"/opt/homebrew/bin/python3.11","detailedDisplayName":"Python 3.11.x"} to {"arch":3,"executable":{"filename":"/opt/homebrew/bin/python3.11","sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.11","mtime":-1,"ctime":-1},"version":{"major":3,"minor":11,"micro":8,"release":{"level":"final","serial":0},"sysVersion":"3.11.8 (main, Feb  6 2024, 21:21:21) [Clang 15.0.0 (clang-1500.1.0.2.5)]"}}
2024-03-25 12:04:12.652 [debug] Environment resolver resolved /opt/homebrew/bin/python3.11 for {"name":"","location":"","kind":"global-other","executable":{"filename":"/opt/homebrew/bin/python3.11","sysPrefix":"","ctime":1710439746947,"mtime":1710439746947},"display":"Python 3.11.x","version":{"major":3,"minor":11,"micro":-1},"arch":1,"distro":{"org":""},"source":[],"id":"/opt/homebrew/bin/python3.11","detailedDisplayName":"Python 3.11.x"} to {"arch":3,"executable":{"filename":"/opt/homebrew/bin/python3.11","sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.11","mtime":-1,"ctime":-1},"version":{"major":3,"minor":11,"micro":8,"release":{"level":"final","serial":0},"sysVersion":"3.11.8 (main, Feb  6 2024, 21:21:21) [Clang 15.0.0 (clang-1500.1.0.2.5)]"}}
2024-03-25 12:04:12.652 [debug] Resolved /opt/homebrew/bin/python3.11 using downstream locator
2024-03-25 12:04:12.652 [debug] Python API env change detected /opt/homebrew/bin/python3.11 update
2024-03-25 12:04:12.652 [debug] Flushing env to cache /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.652 [debug] Resolved /opt/homebrew/bin/python3.11 using downstream locator
2024-03-25 12:04:12.652 [debug] Flushing env to cache /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.654 [debug] Python API env change detected /opt/homebrew/bin/python3.11 update
2024-03-25 12:04:12.655 [debug] Environments added to cache [{"name":"","location":"","kind":"global-other","executable":{"filename":"/usr/bin/python3","sysPrefix":"/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9","ctime":1709179520000,"mtime":1709179520000},"display":"Python 3.9.6 64-bit","version":{"major":3,"minor":9,"micro":6,"release":{"level":"final","serial":0},"sysVersion":"3.9.6 (default, Feb  3 2024, 15:58:27) \n[Clang 15.0.0 (clang-1500.3.9.4)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/usr/bin/python3","detailedDisplayName":"Python 3.9.6 64-bit"},{"name":"","location":"","kind":"global-other","executable":{"filename":"/usr/local/bin/python3","sysPrefix":"/Library/Frameworks/Python.framework/Versions/3.12","ctime":1697737730581,"mtime":1697737729896},"display":"Python 3.12.0 64-bit","version":{"major":3,"minor":12,"micro":0,"release":{"level":"final","serial":0},"sysVersion":"3.12.0 (v3.12.0:0fb18b02c8, Oct  2 2023, 09:45:56) [Clang 13.0.0 (clang-1300.0.29.30)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/usr/local/bin/python3","detailedDisplayName":"Python 3.12.0 64-bit"},{"name":"","location":"","kind":"global-other","executable":{"filename":"/opt/homebrew/bin/python3.10","sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.10","ctime":1711280066232,"mtime":1711280066232},"display":"Python 3.10.14 64-bit","version":{"major":3,"minor":10,"micro":14,"release":{"level":"final","serial":0},"sysVersion":"3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-1500.3.9.4)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/opt/homebrew/bin/python3.10","detailedDisplayName":"Python 3.10.14 64-bit"},{"name":"","location":"","kind":"global-other","executable":{"filename":"/opt/homebrew/bin/python3.11","sysPrefix":"/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.11","ctime":1710439746947,"mtime":1710439746947},"display":"Python 3.11.8 64-bit","version":{"major":3,"minor":11,"micro":8,"release":{"level":"final","serial":0},"sysVersion":"3.11.8 (main, Feb  6 2024, 21:21:21) [Clang 15.0.0 (clang-1500.1.0.2.5)]"},"arch":3,"distro":{"org":""},"source":["path env var"],"id":"/opt/homebrew/bin/python3.11","detailedDisplayName":"Python 3.11.8 64-bit"}]
2024-03-25 12:04:12.655 [debug] Dump environment variables {
    "COMMAND_MODE": "unix2003",
    "HOME": "/Users/tyriar",
    "HOMEBREW_CELLAR": "/opt/homebrew/Cellar",
    "HOMEBREW_PREFIX": "/opt/homebrew",
    "HOMEBREW_REPOSITORY": "/opt/homebrew",
    "INFOPATH": "/opt/homebrew/share/info:",
    "LESS": "-R",
    "LOGNAME": "tyriar",
    "LSCOLORS": "Gxfxcxdxbxegedabagacad",
    "LS_COLORS": "di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43",
    "MANPATH": "/opt/homebrew/share/man::",
    "MallocNanoZone": "0",
    "OLDPWD": "/",
    "ORIGINAL_XDG_CURRENT_DESKTOP": "undefined",
    "PAGER": "less",
    "PWD": "/",
    "SHELL": "/bin/zsh",
    "SHLVL": "0",
    "SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.1Yc7IXFDGh/Listeners",
    "TMPDIR": "/var/folders/nk/960h1fp91k3gpt8_70qg5j0h0000gn/T/",
    "USER": "tyriar",
    "VSCODE_AMD_ENTRYPOINT": "vs/workbench/api/node/extensionHostProcess",
    "VSCODE_CODE_CACHE_PATH": "/Users/tyriar/Library/Application Support/Code - Insiders/CachedData/b0d975fc6370f15570c380f41015b1ca2cdcb791",
    "VSCODE_CRASH_REPORTER_PROCESS_TYPE": "extensionHost",
    "VSCODE_CWD": "/",
    "VSCODE_HANDLES_UNCAUGHT_ERRORS": "true",
    "VSCODE_IPC_HOOK": "/Users/tyriar/Library/Application Support/Code - Insiders/1.88-main.sock",
    "VSCODE_NLS_CONFIG": "{\"locale\":\"en\",\"osLocale\":\"en-au\",\"availableLanguages\":{},\"_languagePackSupport\":true}",
    "VSCODE_PID": "15475",
    "XPC_FLAGS": "0x0",
    "XPC_SERVICE_NAME": "application.com.microsoft.VSCodeInsiders.13688824.13688831",
    "ZSH": "/Users/tyriar/.oh-my-zsh",
    "_": "/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron",
    "__CFBundleIdentifier": "com.microsoft.VSCodeInsiders",
    "__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0xF",
    "ELECTRON_RUN_AS_NODE": "1",
    "VSCODE_L10N_BUNDLE_LOCATION": "",
    "PATH": "/Library/Frameworks/Python.framework/Versions/3.12/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin"
}
2024-03-25 12:04:12.656 [debug] Did we determine shell integration to be working for bash ? true
2024-03-25 12:04:12.656 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.656 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.657 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.657 [info] Python interpreter path: /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.657 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.774 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.780 [debug] Activation Commands received undefined for shell /bin/bash, resource undefined and interpreter /opt/homebrew/bin/python3.11
2024-03-25 12:04:12.780 [debug] Activated environment variables for undefined undefined
2024-03-25 12:04:12.796 [debug] Extension ms-python.vscode-pylance accessed onDidChangeActiveEnvironmentPath with args: undefined
2024-03-25 12:04:12.797 [debug] Extension ms-python.vscode-pylance accessed onDidEnvironmentVariablesChange with args: undefined
2024-03-25 12:04:13.599 [info] Starting Pylance language server.
2024-03-25 12:04:13.599 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:13.602 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:13.602 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:13.603 [debug] Extension ms-python.vscode-pylance accessed getEnvironmentVariables with args: undefined
2024-03-25 12:04:13.604 [debug] Extension ms-python.vscode-pylance accessed getActiveEnvironmentPath with args: undefined
2024-03-25 12:04:13.604 [debug] Extension ms-python.vscode-pylance accessed getActiveEnvironmentPath with args: undefined
2024-03-25 12:04:13.604 [debug] Extension ms-python.vscode-pylance accessed resolveEnvironment with args: {"id":"/opt/homebrew/bin/python3.11","path":"/opt/homebrew/bin/python3.11"}
2024-03-25 12:04:13.604 [debug] Extension ms-python.vscode-pylance accessed resolveEnvironment with args: {"id":"/opt/homebrew/bin/python3.11","path":"/opt/homebrew/bin/python3.11"}
2024-03-25 12:04:13.854 [debug] Delay Trigger[Test Configuration Change]: triggered=2, called=1
2024-03-25 12:04:18.014 [debug] Terminal shell path '/bin/bash' identified as shell 'bash'
2024-03-25 12:04:18.014 [debug] Shell identified as bash 
2024-03-25 12:04:18.014 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:18.145 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:18.147 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:24.516 [debug] Found cached env for /opt/homebrew/bin/python3.11
2024-03-25 12:04:24.855 [debug] Found cached env for /opt/homebrew/bin/python3.11

@Tyriar Tyriar reopened this Mar 25, 2024
@Tyriar Tyriar added the verification-found Issue verification failed label Mar 25, 2024
@karrtikr
Copy link
Author

but there's an exception launching conda (which I don't think is installed) and there's no "worker id"

Sorry, this is actually expected, missed to update the verification steps from before. The important thing to verify here is that the number of environments discovered are still the same, once discovery finishes in both cases.

@karrtikr karrtikr added verified Verification succeeded and removed verification-found Issue verification failed labels Mar 25, 2024
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
…from upstream

Merge pull request #277 from posit-dev/merge/2023.22

Merge vscode-python 2023.22 from upstream
--------------------
Commit message for posit-dev/positron-python@2e3ea32:

handle new upstream `deprecated` response upon parser error

--------------------
Commit message for posit-dev/positron-python@d50c326:

Update yarn.lock

--------------------
Commit message for posit-dev/positron-python@105bf9d:

Merge commit 'a0cddbdf0939729cdb82dca2d129433ad475f51e'

--------------------
Commit message for microsoft/vscode-python@a0cddbd:

bump-release-2023.22 (microsoft/vscode-python#22587)

bump to release version 2023.22 and update package.json
--------------------
Commit message for microsoft/vscode-python@5302d0e:

Revert unsuccessful REPL decoration fix and disable for windows (microsoft/vscode-python#22578)

Reverting microsoft/vscode-python#22572 since it is producing color decoration on weird Python
REPL spot for Windows pwsh users, and disable decoration entirely for
Windows pwsh users temporarily while trying to fix specific problem.

Disable feature for stable. 

Refer: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@bffc9b3:

Fix shell integration decoration bug for Windows pwsh (microsoft/vscode-python#22572)

Attempt to fix colorless and randomized circle decoration for Python
REPL usage by Windows Powershell users.
Resolves: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@e1b54d0:

fix no test id provided for pytest run (microsoft/vscode-python#22569)

fixes microsoft/vscode-python#22567

Now if a user tries to click the "run" button a empty folder (ie a
folder with no tests in it) it will just run pytest with no testIds as
args and notify the user.
--------------------
Commit message for microsoft/vscode-python@61fcf3a:

Properly build deactivate commands for powershell (microsoft/vscode-python#22570)

For microsoft/vscode-python#20950
--------------------
Commit message for microsoft/vscode-python@db6e15e:

Do not throw if initializing deactivate script fails (microsoft/vscode-python#22566)

For microsoft/vscode-python#20950
--------------------
Commit message for microsoft/vscode-python@caa50dc:

Fix shell integration decoration for windows pwsh (microsoft/vscode-python#22560)

Attempting to fix shell integration decoration glitch for windows pwsh
when using Python REPL from VS Code.
Resolves: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@3efb54f:

White space after REPL prompt (microsoft/vscode-python#22549)

There should be white space after new REPL prompt that I override for
purpose of shell integration.
Resolves: microsoft/vscode-python#22548
--------------------
Commit message for microsoft/vscode-python@261ae66:

Improvement: Pass along python interpreter to jedi-language-server (microsoft/vscode-python#22466)

Fixes microsoft/vscode-python#22495

## Before this PR

Overriding the Python interpreter to a different environment that isn't
the current globally-activated base environment would yield no
completions when Jedi is used as the underlying language server.

Example [stackoverflow
question](https://stackoverflow.com/questions/62018436/vscode-intellisense-code-completion-doesnt-work-when-i-am-not-in-base-conda-e)
hitting the same issue.

## After this PR

We now pass along the interpreter path to jedi-language-server as part
of the initial options under `workspace.environmentPath`
([ref](https://github.com/pappasam/jedi-language-server/#workspaceenvironmentpath))
--------------------
Commit message for microsoft/vscode-python@1639753:

switch to conditional error message on check for UUID and port during pytest config (microsoft/vscode-python#22534)

fixes microsoft/vscode-python#19857
--------------------
Commit message for microsoft/vscode-python@9a5363c:

Resolve test suite discovery import errors due to path ordering (microsoft/vscode-python#22454)

[Issue microsoft/vscode-python#22453](microsoft/vscode-python#22453)

- Once starting to run discovery, add the projects root path to PATH at
index 0 so that any further imports will use the projects root directory
and not reference the incorrect directory.
- Since the test suite only allows the start_dir to be one directory
deep, we can conclude that if the start_dir is not "." or contains a
"/", that we need to add that start_dir's parent to PATH. Otherwise, we
simply add the start_dir to PATH.
--------------------
Commit message for microsoft/vscode-python@eb96141:

Use shell integration to denote success/failure  (microsoft/vscode-python#22487)

Resolves: microsoft/vscode-python#22486

Use shell integration to denote success/failure in Python REPL launched
from VS Code.
This would mean having the blue or red decorators based on whether or
not user's command succeeded.
--------------------
Commit message for microsoft/vscode-python@f6e1338:

Use worker threads for fetching conda environments and interpreter related info (microsoft/vscode-python#22481)


--------------------
Commit message for microsoft/vscode-python@3c552f9:

Show warning and allow user to turn off smart send for deprecated Python code (microsoft/vscode-python#22353)

Resolves: microsoft/vscode-python#22341 microsoft/vscode-python#22340

Showing warning message after detecting user is on Python file with
deprecated Python code, and are attempting to run smart send via
shift+enter action. Allow user to turn off this via workspace setting.

---------

Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
--------------------
Commit message for microsoft/vscode-python@ef983f4:

Bump `vscode-tas-client` and fix tests (microsoft/vscode-python#22493)

Closes microsoft/vscode-python#22461

Sinon requires the actual object definition, so we need to point it to
the module file that actually has the function.
--------------------
Commit message for microsoft/vscode-python@9298b2c:

Bump dessant/lock-threads from 4 to 5 (microsoft/vscode-python#22474)

Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads)
from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<p>Learn more about this release from the <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
<h2>v4.0.1</h2>
<p>Learn more about this release from the <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a>
(2023-11-14)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old
behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a
href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>),
closes <a
href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a
href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li>
</ul>
<h3><a
href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a>
(2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a
href="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>),
closes <a
href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a>
(2022-12-04)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a
href="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li>
<li>update docs (<a
href="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li>
</ul>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a>
(2021-09-27)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>input parameter names have changed</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a>
chore(release): 5.0.0</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a>
chore: update package</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a>
chore: update workflow</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a>
feat: lock discussions</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a>
chore: migrate package to ESM</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a>
fix: update dependencies</li>
<li>See full diff in <a
href="https://github.com/dessant/lock-threads/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@e27185a:

Use worker threads for fetching Windows Registry interpreters (microsoft/vscode-python#22479)

For microsoft/vscode-python#22146
--------------------
Commit message for microsoft/vscode-python@7a4de92:

Use `WorkspaceFolder.name` in addition to workspace folder's basename when resolving `${workspaceFolder:name}` syntax in settings (microsoft/vscode-python#22471)

Closes microsoft/vscode-python#22452
--------------------
Commit message for microsoft/vscode-python@fbfa126:

Add 3.12 to conda version list (microsoft/vscode-python#22470)


--------------------
Commit message for microsoft/vscode-python@47552a3:

Install requirements before toml (microsoft/vscode-python#22468)

Fixes microsoft/vscode-python#22423
--------------------
Commit message for microsoft/vscode-python@a1fac81:

If active editor opened is outside the editor, activate the first workspace (microsoft/vscode-python#22450)

For microsoft/vscode-python#22449
--------------------
Commit message for microsoft/vscode-python@b68ddee:

Support deactivating virtual environments without user intervention (microsoft/vscode-python#22405)

Closes microsoft/vscode-python#22448

Adds deactivate script to `PATH`
--------------------
Commit message for microsoft/vscode-python@8d174a8:

Fix shell integration API reliability (microsoft/vscode-python#22446)

microsoft/vscode-python#22440

It leads to terminals activating forever.
--------------------
Commit message for microsoft/vscode-python@1b3c1ea:

Adding `Locked` comments to walkthrough commands (microsoft/vscode-python#22432)

Adds comments to lock command names for walkthrough localization. Only
added Locked comments for walkthrough tiles that are in use and have
commands
--------------------
Commit message for microsoft/vscode-python@2fc9fea:

Revert "Reliably detect whether shell integration is working" (microsoft/vscode-python#22445)

Reverts microsoft/vscode-python#22440

It seems reactivating never finishes after this, although this doesn't
repro when debugging the extension, have to investigate further.
--------------------
Commit message for microsoft/vscode-python@f98caf6:

Add consoleTitle to launch.json properties schema (microsoft/vscode-python#22406)

consoleTitle is effectively an undocumented feature. pydebug accepts the
config key, but vscode will report a problem because it is missing from
the schema. see [this debugpy
issue](microsoft/debugpy#1178) and
[#13040](microsoft/vscode-python#13040)

I used the phrase "console or terminal" because I noticed the name was
represented on both integratedTerminal and internalConsole. I didn't
test externalTerminal.

---------

Co-authored-by: Luciana Abud <[email protected]>
--------------------
Commit message for microsoft/vscode-python@2a976e3:

Reliably detect whether shell integration is working (microsoft/vscode-python#22440)

Closes microsoft/vscode-python#22439

Blocked on https://github.com/microsoft/vscode-distro/pull/822
--------------------
Commit message for microsoft/vscode-python@67b4801:

Improve shell identifier on case-insensitive system (microsoft/vscode-python#22391)

Use case-insensitive regex to remove `.exe`  extension.

See:
microsoft/vscode-python#22036 (comment)
--------------------
Commit message for microsoft/vscode-python@7bc45e5:

Do not attempt to kill the process if it has already exited (microsoft/vscode-python#22424)

Closes microsoft/vscode-python#22420

This bugs seems to have existed every since `rawProcessApi.ts` was
created. `proc.killed` can be `false` even after process has exited.
--------------------
Commit message for microsoft/vscode-python@f6cfa6e:

Remove old code for folder support in interpreter path setting (microsoft/vscode-python#22413)

Closes microsoft/vscode-python#12452

Lead-authored-by: Kartik Raj <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: John H. Ayad <[email protected]>
Co-authored-by: Wasim Lorgat <[email protected]>
Co-authored-by: Shane Saravia <[email protected]>
Co-authored-by: Trysten <[email protected]>
Co-authored-by: JamzumSum <[email protected]>
Co-authored-by: Eleanor Boyd <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Pete Farland <[email protected]>
Co-authored-by: Anthony Kim <[email protected]>
Signed-off-by: GitHub <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
Merge pull request #395 from posit-dev/merge/v2024.2.0

Merge upstream: `v2024.2.0`
--------------------
Commit message for posit-dev/positron-python@7d85a51:

ignore pyright errors in ms testing files

--------------------
Commit message for posit-dev/positron-python@f9a3259:

Bump flask from 3.0.1 to 3.0.2 (posit-dev/positron-python#354)

Bumps [flask](https://github.com/pallets/flask) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@3.0.1...3.0.2)

---
updated-dependencies:
- dependency-name: flask
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@ea812a4:

Bump ipywidgets from 8.1.1 to 8.1.2 (posit-dev/positron-python#368)

Bumps [ipywidgets](https://github.com/jupyter-widgets/ipywidgets) from 8.1.1 to 8.1.2.
- [Release notes](https://github.com/jupyter-widgets/ipywidgets/releases)
- [Commits](jupyter-widgets/ipywidgets@8.1.1...8.1.2)

---
updated-dependencies:
- dependency-name: ipywidgets
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isabel Zimmerman <[email protected]>
--------------------
Commit message for posit-dev/positron-python@e3a5399:

Bump pyright from 1.1.349 to 1.1.351 (posit-dev/positron-python#379)

Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.349 to 1.1.351.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.349...v1.1.351)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@2eeb677:

Bump polars from 0.20.6 to 0.20.11 (posit-dev/positron-python#394)

Bumps [polars](https://github.com/pola-rs/polars) from 0.20.6 to 0.20.11.
- [Release notes](https://github.com/pola-rs/polars/releases)
- [Commits](pola-rs/polars@py-0.20.6...py-0.20.11)

---
updated-dependencies:
- dependency-name: polars
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@573d9fd:

Bump ipykernel from 6.29.0 to 6.29.3 (posit-dev/positron-python#390)

Bumps [ipykernel](https://github.com/ipython/ipykernel) from 6.29.0 to 6.29.3.
- [Release notes](https://github.com/ipython/ipykernel/releases)
- [Changelog](https://github.com/ipython/ipykernel/blob/main/CHANGELOG.md)
- [Commits](ipython/ipykernel@v6.29.0...v6.29.3)

---
updated-dependencies:
- dependency-name: ipykernel
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@334b383:

update package.json

--------------------
Commit message for posit-dev/positron-python@7ce08b1:

Merge tag 'v2024.2.0' into merge/v2024.2.0

--------------------
Commit message for posit-dev/positron-python@063ba15:

Finalized-release-2024.2.0 (posit-dev/positron-python#22996)

Finalized release 2024.2.0: removing -rc
--------------------
Commit message for posit-dev/positron-python@3eef025:

Bump release 2024.2 (posit-dev/positron-python#22972)

Bump release 2024.2
--------------------
Commit message for posit-dev/positron-python@1fbd77b:

 skip tests, pytest upstream regression (posit-dev/positron-python#22974)

Short-term fix to stop CI from failing due to a regression upstream from
pytest. See issue for details:
microsoft/vscode-python#22965.
--------------------
Commit message for microsoft/vscode-python@4fca030:

Adding GDPR tag for isFirstSession (microsoft/vscode-python#22955)


--------------------
Commit message for microsoft/vscode-python@ba94553:

Modify telemetry to contain trigger time as property (microsoft/vscode-python#22941)


--------------------
Commit message for microsoft/vscode-python@178a0b2:

Fix bug with symlink for pytest execution (microsoft/vscode-python#22952)

Fixes microsoft/vscode-python#22938
--------------------
Commit message for microsoft/vscode-python@bae7d40:

Update vscode-tas-client version (microsoft/vscode-python#22876)


--------------------
Commit message for microsoft/vscode-python@75ed73e:

Fix Bug with Pytest when using symlinked workspaces (microsoft/vscode-python#22885)

fixes microsoft/vscode-python#22658

also implements switching to arg mapping which is this issue here:
microsoft/vscode-python#22076

---------

Co-authored-by: Karthik Nadig <[email protected]>
--------------------
Commit message for microsoft/vscode-python@e53651d:

Prevent first Python command being lost (microsoft/vscode-python#22902)

Fixes: microsoft/vscode-python#22673
Fixes: microsoft/vscode-python#22545
Fixes: microsoft/vscode-python#22691 

Making best effort to address issue where very first command sent to
REPL via Terminal gets ignored, or gets pasted both in Terminal and in
REPL.

With the fix, we observe whether Python REPL is launched in Terminal via
VS Code's `onDidWriteTerminalData` and send the command, or wait three
seconds as a fallback mechanism.

These two combined together will significantly reduce or resolve
all-together the chance of very first command being swollen up or gets
pasted twice in Terminal and REPL previously where it did not have
context of whether Python REPL instance have started inside the Terminal
or not.
--------------------
Commit message for microsoft/vscode-python@a60fbd5:

Add GDPR tags for new Pylance properties (microsoft/vscode-python#22922)


--------------------
Commit message for microsoft/vscode-python@aff0b05:

Use python debugger in testing (microsoft/vscode-python#22903)

closed: microsoft/vscode-python-debugger#174
--------------------
Commit message for microsoft/vscode-python@84734a8:

Updating installed extensions section of README.md (microsoft/vscode-python#22893)

Adding the Python Debugger to the installed extensions section of the
README.
--------------------
Commit message for microsoft/vscode-python@2159238:

Bump actions/setup-python from 4 to 5 in /.github/actions/build-vsix (microsoft/vscode-python#22602)

Bumps [actions/setup-python](https://github.com/actions/setup-python)
from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/setup-python/releases">actions/setup-python's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, we update node version runtime from node16
to node20 (<a
href="https://redirect.github.com/actions/setup-python/pull/772">actions/setup-python#772</a>).
Besides, we update dependencies to the latest versions.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0">https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0</a></p>
<h2>v4.8.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release we added support for GraalPy (<a
href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a>).
You can use this snippet to set up GraalPy:</p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4 
  with:
    python-version: 'graalpy-22.3' 
- run: python my_script.py
</code></pre>
<p>Besides, the release contains such changes as:</p>
<ul>
<li>Trim python version when reading from file by <a
href="https://github.com/FerranPares"><code>@​FerranPares</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li>Use non-deprecated versions in examples by <a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
<li>Change deprecation comment to past tense by <a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/723">actions/setup-python#723</a></li>
<li>Bump <code>@​babel/traverse</code> from 7.9.0 to 7.23.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/743">actions/setup-python#743</a></li>
<li>advanced-usage.md: Encourage the use actions/checkout@v4 by <a
href="https://github.com/cclauss"><code>@​cclauss</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/729">actions/setup-python#729</a></li>
<li>Examples now use checkout@v4 by <a
href="https://github.com/simonw"><code>@​simonw</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/738">actions/setup-python#738</a></li>
<li>Update actions/checkout to v4 by <a
href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/761">actions/setup-python#761</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/FerranPares"><code>@​FerranPares</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li><a href="https://github.com/timfel"><code>@​timfel</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a></li>
<li><a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4...v4.8.0">https://github.com/actions/setup-python/compare/v4...v4.8.0</a></p>
<h2>v4.7.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump word-wrap from 1.2.3 to 1.2.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li>
<li>Add range validation for toml files by <a
href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p>
<h2>v4.7.0</h2>
<p>In scope of this release, the support for reading python version from
pyproject.toml was added (<a
href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a>).</p>
<pre lang="yaml"><code>      - name: Setup Python
        uses: actions/setup-python@v4
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/setup-python/commit/0a5c61591373683505ea898e09a3ea4f39ef2b9c"><code>0a5c615</code></a>
Update action to node20 (<a
href="https://redirect.github.com/actions/setup-python/issues/772">#772</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/0ae58361cdfd39e2950bed97a1e26aa20c3d8955"><code>0ae5836</code></a>
Add example of GraalPy to docs (<a
href="https://redirect.github.com/actions/setup-python/issues/773">#773</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/b64ffcaf5b410884ad320a9cfac8866006a109aa"><code>b64ffca</code></a>
update actions/checkout to v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/761">#761</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/8d2896179abf658742de432b3f203d2c2d86a587"><code>8d28961</code></a>
Examples now use checkout@v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/738">#738</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/7bc6abb01e0555719edc2dbca70a2fde309e5e56"><code>7bc6abb</code></a>
advanced-usage.md: Encourage the use actions/checkout@v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/729">#729</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/e8111cec9d3dc15220d8a3b638f08419f57b906a"><code>e8111ce</code></a>
Bump <code>@​babel/traverse</code> from 7.9.0 to 7.23.2 (<a
href="https://redirect.github.com/actions/setup-python/issues/743">#743</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/a00ea43da65e7c04d2bdae58b3afecd77057eb9e"><code>a00ea43</code></a>
add fix for graalpy ci (<a
href="https://redirect.github.com/actions/setup-python/issues/741">#741</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/8635b1ccc5934e73ed3510980fd2e7790b85839b"><code>8635b1c</code></a>
Change deprecation comment to past tense (<a
href="https://redirect.github.com/actions/setup-python/issues/723">#723</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/f6cc428f535856f9c23558d01765a42a4d6cf758"><code>f6cc428</code></a>
Use non-deprecated versions in examples (<a
href="https://redirect.github.com/actions/setup-python/issues/724">#724</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/5f2af211d616f86005883b44826180b21abb4060"><code>5f2af21</code></a>
Add GraalPy support (<a
href="https://redirect.github.com/actions/setup-python/issues/694">#694</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/setup-python/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@83cf53b:

Add "isMeasurement" for LANGUAGE_SERVER_TRIGGER_DURATION (microsoft/vscode-python#22912)

cc/ @cwebster-99
--------------------
Commit message for microsoft/vscode-python@7be33eb:

Add more shell integration sequences to check for (microsoft/vscode-python#22911)

Based on discussion with Daniel

For microsoft/vscode-python#22440
--------------------
Commit message for microsoft/vscode-python@6838ccf:

Do not activate microvenv if terminal.activateEnvironment is set to false and when not in terminal experiment (microsoft/vscode-python#22909)


--------------------
Commit message for microsoft/vscode-python@2dc158e:

Log options being passed when using environment collection APIs (microsoft/vscode-python#22907)

For microsoft/vscode-python#22899
--------------------
Commit message for microsoft/vscode-python@5f971ae:

Prepend `PATH` both at shell integration and process creation (microsoft/vscode-python#22905)


--------------------
Commit message for microsoft/vscode-python@5174d5c:

Improve shell integration reliability for zsh (microsoft/vscode-python#22891)

Closes microsoft/vscode-python#22881

If status changes, re-run activation. Also persist once we know shell
integration works for a shell.
--------------------
Commit message for microsoft/vscode-python@b0c34e3:

Add UnicodeDecodeError catching (microsoft/vscode-python#22873)

Resolve `UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in
position 48995: unexpected end of data`

Co-authored-by: Aydar Kamaltdinov <[email protected]>
--------------------
Commit message for microsoft/vscode-python@8496dfe:

Remove experimental flag for create env prompt (microsoft/vscode-python#22892)

Remove experimental flag for `python.createEnvironment.trigger`.
--------------------
Commit message for microsoft/vscode-python@c4c05a6:

update tree comparison for tests to be order independent for children (microsoft/vscode-python#22832)

following the introduction of pytest 8, the order in which children were
listed changed. Since the order is not important, this updates the tests
to make the tests not consider order of children when comparing actual
and expected outcomes of test runs.
--------------------
Commit message for microsoft/vscode-python@4030717:

Use terminal data write event to figure out whether shell integration is working (microsoft/vscode-python#22872)

Closes microsoft/vscode-python#22439

Blocked on microsoft/vscode#204616
--------------------
Commit message for microsoft/vscode-python@d674a17:

Fix Run Recent Command Caching Issue (microsoft/vscode-python#22867)

Resolves: microsoft/vscode-python#22811

Fixing caching issue where users were experiencing cached
success/failure decoration that were impacted when using `Terminal: Run
Recent Command` on success/failure commands
--------------------
Commit message for microsoft/vscode-python@c0bf1b7:

Improve time taken to trigger language server startup once extension activation is triggered (microsoft/vscode-python#22514)

For microsoft/vscode-python#22146 

Improves time taken to trigger language server startup once extension
activation is triggered

- Do not block discovery on windows registry
- Do not blocking auto-selection on validation of all interpreters
- Make Windows Path locator faster
--------------------
Commit message for microsoft/vscode-python@20c1a10:

Log when running Python file (microsoft/vscode-python#22851)

For microsoft/vscode-python#22711
--------------------
Commit message for microsoft/vscode-python@8aaa70e:

Fix venv activation for cshell (microsoft/vscode-python#22852)

Closes microsoft/vscode-python#22822

Use current shell to figure out whether shell integration is working,
even when using fallback shell for getting environment variables.
--------------------
Commit message for microsoft/vscode-python@1626c46:

Do not run commands to check whether shell integration is working (microsoft/vscode-python#22850)

Closes microsoft/vscode-python#22774 closes
microsoft/vscode-python#22743
--------------------
Commit message for microsoft/vscode-python@13a6727:

include multiple pytest versions in PR check (microsoft/vscode-python#22813)

update PR check workflow to include testing Python tests against 3
versions of pytest: pre-release, stable release, and oldest supported
version.

---------

Co-authored-by: Karthik Nadig <[email protected]>
--------------------
Commit message for microsoft/vscode-python@6e8c56c:

Bump dev version 2024.1 (microsoft/vscode-python#22805)



Lead-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Aydar Kamaltdinov <[email protected]>
Co-authored-by: paulacamargo25 <[email protected]>
Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Anthony Kim <[email protected]>
Co-authored-by: Isabel Zimmerman <[email protected]>
Co-authored-by: Eleanor Boyd <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: GitHub <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
…from upstream

Merge pull request #277 from posit-dev/merge/2023.22

Merge vscode-python 2023.22 from upstream
--------------------
Commit message for posit-dev/positron-python@2e3ea32:

handle new upstream `deprecated` response upon parser error

--------------------
Commit message for posit-dev/positron-python@d50c326:

Update yarn.lock

--------------------
Commit message for posit-dev/positron-python@105bf9d:

Merge commit 'a0cddbdf0939729cdb82dca2d129433ad475f51e'

--------------------
Commit message for microsoft/vscode-python@a0cddbd:

bump-release-2023.22 (microsoft/vscode-python#22587)

bump to release version 2023.22 and update package.json
--------------------
Commit message for microsoft/vscode-python@5302d0e:

Revert unsuccessful REPL decoration fix and disable for windows (microsoft/vscode-python#22578)

Reverting microsoft/vscode-python#22572 since it is producing color decoration on weird Python
REPL spot for Windows pwsh users, and disable decoration entirely for
Windows pwsh users temporarily while trying to fix specific problem.

Disable feature for stable. 

Refer: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@bffc9b3:

Fix shell integration decoration bug for Windows pwsh (microsoft/vscode-python#22572)

Attempt to fix colorless and randomized circle decoration for Python
REPL usage by Windows Powershell users.
Resolves: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@e1b54d0:

fix no test id provided for pytest run (microsoft/vscode-python#22569)

fixes microsoft/vscode-python#22567

Now if a user tries to click the "run" button a empty folder (ie a
folder with no tests in it) it will just run pytest with no testIds as
args and notify the user.
--------------------
Commit message for microsoft/vscode-python@61fcf3a:

Properly build deactivate commands for powershell (microsoft/vscode-python#22570)

For microsoft/vscode-python#20950
--------------------
Commit message for microsoft/vscode-python@db6e15e:

Do not throw if initializing deactivate script fails (microsoft/vscode-python#22566)

For microsoft/vscode-python#20950
--------------------
Commit message for microsoft/vscode-python@caa50dc:

Fix shell integration decoration for windows pwsh (microsoft/vscode-python#22560)

Attempting to fix shell integration decoration glitch for windows pwsh
when using Python REPL from VS Code.
Resolves: microsoft/vscode-python#22546 microsoft/vscode-python#22535
--------------------
Commit message for microsoft/vscode-python@3efb54f:

White space after REPL prompt (microsoft/vscode-python#22549)

There should be white space after new REPL prompt that I override for
purpose of shell integration.
Resolves: microsoft/vscode-python#22548
--------------------
Commit message for microsoft/vscode-python@261ae66:

Improvement: Pass along python interpreter to jedi-language-server (microsoft/vscode-python#22466)

Fixes microsoft/vscode-python#22495

## Before this PR

Overriding the Python interpreter to a different environment that isn't
the current globally-activated base environment would yield no
completions when Jedi is used as the underlying language server.

Example [stackoverflow
question](https://stackoverflow.com/questions/62018436/vscode-intellisense-code-completion-doesnt-work-when-i-am-not-in-base-conda-e)
hitting the same issue.

## After this PR

We now pass along the interpreter path to jedi-language-server as part
of the initial options under `workspace.environmentPath`
([ref](https://github.com/pappasam/jedi-language-server/#workspaceenvironmentpath))
--------------------
Commit message for microsoft/vscode-python@1639753:

switch to conditional error message on check for UUID and port during pytest config (microsoft/vscode-python#22534)

fixes microsoft/vscode-python#19857
--------------------
Commit message for microsoft/vscode-python@9a5363c:

Resolve test suite discovery import errors due to path ordering (microsoft/vscode-python#22454)

[Issue microsoft/vscode-python#22453](microsoft/vscode-python#22453)

- Once starting to run discovery, add the projects root path to PATH at
index 0 so that any further imports will use the projects root directory
and not reference the incorrect directory.
- Since the test suite only allows the start_dir to be one directory
deep, we can conclude that if the start_dir is not "." or contains a
"/", that we need to add that start_dir's parent to PATH. Otherwise, we
simply add the start_dir to PATH.
--------------------
Commit message for microsoft/vscode-python@eb96141:

Use shell integration to denote success/failure  (microsoft/vscode-python#22487)

Resolves: microsoft/vscode-python#22486

Use shell integration to denote success/failure in Python REPL launched
from VS Code.
This would mean having the blue or red decorators based on whether or
not user's command succeeded.
--------------------
Commit message for microsoft/vscode-python@f6e1338:

Use worker threads for fetching conda environments and interpreter related info (microsoft/vscode-python#22481)


--------------------
Commit message for microsoft/vscode-python@3c552f9:

Show warning and allow user to turn off smart send for deprecated Python code (microsoft/vscode-python#22353)

Resolves: microsoft/vscode-python#22341 microsoft/vscode-python#22340

Showing warning message after detecting user is on Python file with
deprecated Python code, and are attempting to run smart send via
shift+enter action. Allow user to turn off this via workspace setting.

---------

Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
--------------------
Commit message for microsoft/vscode-python@ef983f4:

Bump `vscode-tas-client` and fix tests (microsoft/vscode-python#22493)

Closes microsoft/vscode-python#22461

Sinon requires the actual object definition, so we need to point it to
the module file that actually has the function.
--------------------
Commit message for microsoft/vscode-python@9298b2c:

Bump dessant/lock-threads from 4 to 5 (microsoft/vscode-python#22474)

Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads)
from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<p>Learn more about this release from the <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
<h2>v4.0.1</h2>
<p>Learn more about this release from the <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a>
(2023-11-14)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old
behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a
href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>),
closes <a
href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a
href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li>
</ul>
<h3><a
href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a>
(2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a
href="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>),
closes <a
href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a>
(2022-12-04)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a
href="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li>
<li>update docs (<a
href="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li>
</ul>
<h2><a
href="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a>
(2021-09-27)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>input parameter names have changed</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a>
chore(release): 5.0.0</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a>
chore: update package</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a>
chore: update workflow</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a>
feat: lock discussions</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a>
chore: migrate package to ESM</li>
<li><a
href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a>
fix: update dependencies</li>
<li>See full diff in <a
href="https://github.com/dessant/lock-threads/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@e27185a:

Use worker threads for fetching Windows Registry interpreters (microsoft/vscode-python#22479)

For microsoft/vscode-python#22146
--------------------
Commit message for microsoft/vscode-python@7a4de92:

Use `WorkspaceFolder.name` in addition to workspace folder's basename when resolving `${workspaceFolder:name}` syntax in settings (microsoft/vscode-python#22471)

Closes microsoft/vscode-python#22452
--------------------
Commit message for microsoft/vscode-python@fbfa126:

Add 3.12 to conda version list (microsoft/vscode-python#22470)


--------------------
Commit message for microsoft/vscode-python@47552a3:

Install requirements before toml (microsoft/vscode-python#22468)

Fixes microsoft/vscode-python#22423
--------------------
Commit message for microsoft/vscode-python@a1fac81:

If active editor opened is outside the editor, activate the first workspace (microsoft/vscode-python#22450)

For microsoft/vscode-python#22449
--------------------
Commit message for microsoft/vscode-python@b68ddee:

Support deactivating virtual environments without user intervention (microsoft/vscode-python#22405)

Closes microsoft/vscode-python#22448

Adds deactivate script to `PATH`
--------------------
Commit message for microsoft/vscode-python@8d174a8:

Fix shell integration API reliability (microsoft/vscode-python#22446)

microsoft/vscode-python#22440

It leads to terminals activating forever.
--------------------
Commit message for microsoft/vscode-python@1b3c1ea:

Adding `Locked` comments to walkthrough commands (microsoft/vscode-python#22432)

Adds comments to lock command names for walkthrough localization. Only
added Locked comments for walkthrough tiles that are in use and have
commands
--------------------
Commit message for microsoft/vscode-python@2fc9fea:

Revert "Reliably detect whether shell integration is working" (microsoft/vscode-python#22445)

Reverts microsoft/vscode-python#22440

It seems reactivating never finishes after this, although this doesn't
repro when debugging the extension, have to investigate further.
--------------------
Commit message for microsoft/vscode-python@f98caf6:

Add consoleTitle to launch.json properties schema (microsoft/vscode-python#22406)

consoleTitle is effectively an undocumented feature. pydebug accepts the
config key, but vscode will report a problem because it is missing from
the schema. see [this debugpy
issue](microsoft/debugpy#1178) and
[#13040](microsoft/vscode-python#13040)

I used the phrase "console or terminal" because I noticed the name was
represented on both integratedTerminal and internalConsole. I didn't
test externalTerminal.

---------

Co-authored-by: Luciana Abud <[email protected]>
--------------------
Commit message for microsoft/vscode-python@2a976e3:

Reliably detect whether shell integration is working (microsoft/vscode-python#22440)

Closes microsoft/vscode-python#22439

Blocked on https://github.com/microsoft/vscode-distro/pull/822
--------------------
Commit message for microsoft/vscode-python@67b4801:

Improve shell identifier on case-insensitive system (microsoft/vscode-python#22391)

Use case-insensitive regex to remove `.exe`  extension.

See:
microsoft/vscode-python#22036 (comment)
--------------------
Commit message for microsoft/vscode-python@7bc45e5:

Do not attempt to kill the process if it has already exited (microsoft/vscode-python#22424)

Closes microsoft/vscode-python#22420

This bugs seems to have existed every since `rawProcessApi.ts` was
created. `proc.killed` can be `false` even after process has exited.
--------------------
Commit message for microsoft/vscode-python@f6cfa6e:

Remove old code for folder support in interpreter path setting (microsoft/vscode-python#22413)

Closes microsoft/vscode-python#12452

Lead-authored-by: Kartik Raj <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: John H. Ayad <[email protected]>
Co-authored-by: Wasim Lorgat <[email protected]>
Co-authored-by: Shane Saravia <[email protected]>
Co-authored-by: Trysten <[email protected]>
Co-authored-by: JamzumSum <[email protected]>
Co-authored-by: Eleanor Boyd <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Pete Farland <[email protected]>
Co-authored-by: Anthony Kim <[email protected]>
Signed-off-by: GitHub <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue Mar 28, 2024
Merge pull request #395 from posit-dev/merge/v2024.2.0

Merge upstream: `v2024.2.0`
--------------------
Commit message for posit-dev/positron-python@7d85a51:

ignore pyright errors in ms testing files

--------------------
Commit message for posit-dev/positron-python@f9a3259:

Bump flask from 3.0.1 to 3.0.2 (posit-dev/positron-python#354)

Bumps [flask](https://github.com/pallets/flask) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@3.0.1...3.0.2)

---
updated-dependencies:
- dependency-name: flask
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@ea812a4:

Bump ipywidgets from 8.1.1 to 8.1.2 (posit-dev/positron-python#368)

Bumps [ipywidgets](https://github.com/jupyter-widgets/ipywidgets) from 8.1.1 to 8.1.2.
- [Release notes](https://github.com/jupyter-widgets/ipywidgets/releases)
- [Commits](jupyter-widgets/ipywidgets@8.1.1...8.1.2)

---
updated-dependencies:
- dependency-name: ipywidgets
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isabel Zimmerman <[email protected]>
--------------------
Commit message for posit-dev/positron-python@e3a5399:

Bump pyright from 1.1.349 to 1.1.351 (posit-dev/positron-python#379)

Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.349 to 1.1.351.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.349...v1.1.351)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@2eeb677:

Bump polars from 0.20.6 to 0.20.11 (posit-dev/positron-python#394)

Bumps [polars](https://github.com/pola-rs/polars) from 0.20.6 to 0.20.11.
- [Release notes](https://github.com/pola-rs/polars/releases)
- [Commits](pola-rs/polars@py-0.20.6...py-0.20.11)

---
updated-dependencies:
- dependency-name: polars
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@573d9fd:

Bump ipykernel from 6.29.0 to 6.29.3 (posit-dev/positron-python#390)

Bumps [ipykernel](https://github.com/ipython/ipykernel) from 6.29.0 to 6.29.3.
- [Release notes](https://github.com/ipython/ipykernel/releases)
- [Changelog](https://github.com/ipython/ipykernel/blob/main/CHANGELOG.md)
- [Commits](ipython/ipykernel@v6.29.0...v6.29.3)

---
updated-dependencies:
- dependency-name: ipykernel
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for posit-dev/positron-python@334b383:

update package.json

--------------------
Commit message for posit-dev/positron-python@7ce08b1:

Merge tag 'v2024.2.0' into merge/v2024.2.0

--------------------
Commit message for posit-dev/positron-python@063ba15:

Finalized-release-2024.2.0 (posit-dev/positron-python#22996)

Finalized release 2024.2.0: removing -rc
--------------------
Commit message for posit-dev/positron-python@3eef025:

Bump release 2024.2 (posit-dev/positron-python#22972)

Bump release 2024.2
--------------------
Commit message for posit-dev/positron-python@1fbd77b:

 skip tests, pytest upstream regression (posit-dev/positron-python#22974)

Short-term fix to stop CI from failing due to a regression upstream from
pytest. See issue for details:
microsoft/vscode-python#22965.
--------------------
Commit message for microsoft/vscode-python@4fca030:

Adding GDPR tag for isFirstSession (microsoft/vscode-python#22955)


--------------------
Commit message for microsoft/vscode-python@ba94553:

Modify telemetry to contain trigger time as property (microsoft/vscode-python#22941)


--------------------
Commit message for microsoft/vscode-python@178a0b2:

Fix bug with symlink for pytest execution (microsoft/vscode-python#22952)

Fixes microsoft/vscode-python#22938
--------------------
Commit message for microsoft/vscode-python@bae7d40:

Update vscode-tas-client version (microsoft/vscode-python#22876)


--------------------
Commit message for microsoft/vscode-python@75ed73e:

Fix Bug with Pytest when using symlinked workspaces (microsoft/vscode-python#22885)

fixes microsoft/vscode-python#22658

also implements switching to arg mapping which is this issue here:
microsoft/vscode-python#22076

---------

Co-authored-by: Karthik Nadig <[email protected]>
--------------------
Commit message for microsoft/vscode-python@e53651d:

Prevent first Python command being lost (microsoft/vscode-python#22902)

Fixes: microsoft/vscode-python#22673
Fixes: microsoft/vscode-python#22545
Fixes: microsoft/vscode-python#22691 

Making best effort to address issue where very first command sent to
REPL via Terminal gets ignored, or gets pasted both in Terminal and in
REPL.

With the fix, we observe whether Python REPL is launched in Terminal via
VS Code's `onDidWriteTerminalData` and send the command, or wait three
seconds as a fallback mechanism.

These two combined together will significantly reduce or resolve
all-together the chance of very first command being swollen up or gets
pasted twice in Terminal and REPL previously where it did not have
context of whether Python REPL instance have started inside the Terminal
or not.
--------------------
Commit message for microsoft/vscode-python@a60fbd5:

Add GDPR tags for new Pylance properties (microsoft/vscode-python#22922)


--------------------
Commit message for microsoft/vscode-python@aff0b05:

Use python debugger in testing (microsoft/vscode-python#22903)

closed: microsoft/vscode-python-debugger#174
--------------------
Commit message for microsoft/vscode-python@84734a8:

Updating installed extensions section of README.md (microsoft/vscode-python#22893)

Adding the Python Debugger to the installed extensions section of the
README.
--------------------
Commit message for microsoft/vscode-python@2159238:

Bump actions/setup-python from 4 to 5 in /.github/actions/build-vsix (microsoft/vscode-python#22602)

Bumps [actions/setup-python](https://github.com/actions/setup-python)
from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/setup-python/releases">actions/setup-python's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, we update node version runtime from node16
to node20 (<a
href="https://redirect.github.com/actions/setup-python/pull/772">actions/setup-python#772</a>).
Besides, we update dependencies to the latest versions.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0">https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0</a></p>
<h2>v4.8.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release we added support for GraalPy (<a
href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a>).
You can use this snippet to set up GraalPy:</p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4 
  with:
    python-version: 'graalpy-22.3' 
- run: python my_script.py
</code></pre>
<p>Besides, the release contains such changes as:</p>
<ul>
<li>Trim python version when reading from file by <a
href="https://github.com/FerranPares"><code>@​FerranPares</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li>Use non-deprecated versions in examples by <a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
<li>Change deprecation comment to past tense by <a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/723">actions/setup-python#723</a></li>
<li>Bump <code>@​babel/traverse</code> from 7.9.0 to 7.23.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/743">actions/setup-python#743</a></li>
<li>advanced-usage.md: Encourage the use actions/checkout@v4 by <a
href="https://github.com/cclauss"><code>@​cclauss</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/729">actions/setup-python#729</a></li>
<li>Examples now use checkout@v4 by <a
href="https://github.com/simonw"><code>@​simonw</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/738">actions/setup-python#738</a></li>
<li>Update actions/checkout to v4 by <a
href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/761">actions/setup-python#761</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/FerranPares"><code>@​FerranPares</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li><a href="https://github.com/timfel"><code>@​timfel</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a></li>
<li><a
href="https://github.com/jeffwidman"><code>@​jeffwidman</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4...v4.8.0">https://github.com/actions/setup-python/compare/v4...v4.8.0</a></p>
<h2>v4.7.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump word-wrap from 1.2.3 to 1.2.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li>
<li>Add range validation for toml files by <a
href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p>
<h2>v4.7.0</h2>
<p>In scope of this release, the support for reading python version from
pyproject.toml was added (<a
href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a>).</p>
<pre lang="yaml"><code>      - name: Setup Python
        uses: actions/setup-python@v4
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/setup-python/commit/0a5c61591373683505ea898e09a3ea4f39ef2b9c"><code>0a5c615</code></a>
Update action to node20 (<a
href="https://redirect.github.com/actions/setup-python/issues/772">#772</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/0ae58361cdfd39e2950bed97a1e26aa20c3d8955"><code>0ae5836</code></a>
Add example of GraalPy to docs (<a
href="https://redirect.github.com/actions/setup-python/issues/773">#773</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/b64ffcaf5b410884ad320a9cfac8866006a109aa"><code>b64ffca</code></a>
update actions/checkout to v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/761">#761</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/8d2896179abf658742de432b3f203d2c2d86a587"><code>8d28961</code></a>
Examples now use checkout@v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/738">#738</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/7bc6abb01e0555719edc2dbca70a2fde309e5e56"><code>7bc6abb</code></a>
advanced-usage.md: Encourage the use actions/checkout@v4 (<a
href="https://redirect.github.com/actions/setup-python/issues/729">#729</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/e8111cec9d3dc15220d8a3b638f08419f57b906a"><code>e8111ce</code></a>
Bump <code>@​babel/traverse</code> from 7.9.0 to 7.23.2 (<a
href="https://redirect.github.com/actions/setup-python/issues/743">#743</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/a00ea43da65e7c04d2bdae58b3afecd77057eb9e"><code>a00ea43</code></a>
add fix for graalpy ci (<a
href="https://redirect.github.com/actions/setup-python/issues/741">#741</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/8635b1ccc5934e73ed3510980fd2e7790b85839b"><code>8635b1c</code></a>
Change deprecation comment to past tense (<a
href="https://redirect.github.com/actions/setup-python/issues/723">#723</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/f6cc428f535856f9c23558d01765a42a4d6cf758"><code>f6cc428</code></a>
Use non-deprecated versions in examples (<a
href="https://redirect.github.com/actions/setup-python/issues/724">#724</a>)</li>
<li><a
href="https://github.com/actions/setup-python/commit/5f2af211d616f86005883b44826180b21abb4060"><code>5f2af21</code></a>
Add GraalPy support (<a
href="https://redirect.github.com/actions/setup-python/issues/694">#694</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/setup-python/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------------------
Commit message for microsoft/vscode-python@83cf53b:

Add "isMeasurement" for LANGUAGE_SERVER_TRIGGER_DURATION (microsoft/vscode-python#22912)

cc/ @cwebster-99
--------------------
Commit message for microsoft/vscode-python@7be33eb:

Add more shell integration sequences to check for (microsoft/vscode-python#22911)

Based on discussion with Daniel

For microsoft/vscode-python#22440
--------------------
Commit message for microsoft/vscode-python@6838ccf:

Do not activate microvenv if terminal.activateEnvironment is set to false and when not in terminal experiment (microsoft/vscode-python#22909)


--------------------
Commit message for microsoft/vscode-python@2dc158e:

Log options being passed when using environment collection APIs (microsoft/vscode-python#22907)

For microsoft/vscode-python#22899
--------------------
Commit message for microsoft/vscode-python@5f971ae:

Prepend `PATH` both at shell integration and process creation (microsoft/vscode-python#22905)


--------------------
Commit message for microsoft/vscode-python@5174d5c:

Improve shell integration reliability for zsh (microsoft/vscode-python#22891)

Closes microsoft/vscode-python#22881

If status changes, re-run activation. Also persist once we know shell
integration works for a shell.
--------------------
Commit message for microsoft/vscode-python@b0c34e3:

Add UnicodeDecodeError catching (microsoft/vscode-python#22873)

Resolve `UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in
position 48995: unexpected end of data`

Co-authored-by: Aydar Kamaltdinov <[email protected]>
--------------------
Commit message for microsoft/vscode-python@8496dfe:

Remove experimental flag for create env prompt (microsoft/vscode-python#22892)

Remove experimental flag for `python.createEnvironment.trigger`.
--------------------
Commit message for microsoft/vscode-python@c4c05a6:

update tree comparison for tests to be order independent for children (microsoft/vscode-python#22832)

following the introduction of pytest 8, the order in which children were
listed changed. Since the order is not important, this updates the tests
to make the tests not consider order of children when comparing actual
and expected outcomes of test runs.
--------------------
Commit message for microsoft/vscode-python@4030717:

Use terminal data write event to figure out whether shell integration is working (microsoft/vscode-python#22872)

Closes microsoft/vscode-python#22439

Blocked on microsoft/vscode#204616
--------------------
Commit message for microsoft/vscode-python@d674a17:

Fix Run Recent Command Caching Issue (microsoft/vscode-python#22867)

Resolves: microsoft/vscode-python#22811

Fixing caching issue where users were experiencing cached
success/failure decoration that were impacted when using `Terminal: Run
Recent Command` on success/failure commands
--------------------
Commit message for microsoft/vscode-python@c0bf1b7:

Improve time taken to trigger language server startup once extension activation is triggered (microsoft/vscode-python#22514)

For microsoft/vscode-python#22146 

Improves time taken to trigger language server startup once extension
activation is triggered

- Do not block discovery on windows registry
- Do not blocking auto-selection on validation of all interpreters
- Make Windows Path locator faster
--------------------
Commit message for microsoft/vscode-python@20c1a10:

Log when running Python file (microsoft/vscode-python#22851)

For microsoft/vscode-python#22711
--------------------
Commit message for microsoft/vscode-python@8aaa70e:

Fix venv activation for cshell (microsoft/vscode-python#22852)

Closes microsoft/vscode-python#22822

Use current shell to figure out whether shell integration is working,
even when using fallback shell for getting environment variables.
--------------------
Commit message for microsoft/vscode-python@1626c46:

Do not run commands to check whether shell integration is working (microsoft/vscode-python#22850)

Closes microsoft/vscode-python#22774 closes
microsoft/vscode-python#22743
--------------------
Commit message for microsoft/vscode-python@13a6727:

include multiple pytest versions in PR check (microsoft/vscode-python#22813)

update PR check workflow to include testing Python tests against 3
versions of pytest: pre-release, stable release, and oldest supported
version.

---------

Co-authored-by: Karthik Nadig <[email protected]>
--------------------
Commit message for microsoft/vscode-python@6e8c56c:

Bump dev version 2024.1 (microsoft/vscode-python#22805)



Lead-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Aydar Kamaltdinov <[email protected]>
Co-authored-by: paulacamargo25 <[email protected]>
Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Anthony Kim <[email protected]>
Co-authored-by: Isabel Zimmerman <[email protected]>
Co-authored-by: Eleanor Boyd <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: GitHub <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 5, 2024
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants