Updated _find_left_bracket function used in pytest discovery to fix bug #17955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I ran black to fix the linting error, but I don't know why the venv check failed. I also see a previously approved pull request (#17881) that already solved the problem in a different and probably better way. |
|
@scwilbanks Thanks for the PR. I think we want to go with the fix here #17881. The venv test failed due to Can you test with the build from the PR #17881 and confirm that it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #17954, #17951.
Instead of assuming an equal number of open and closed brackets as the current function does, this change assumes that the first open bracket of the last double colon "::" will be the bracket it is looking for. Since the testname will correspond to a python function, which cannot contain open brackets, the first open bracket must be it.