Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python.pythonPath experiment #18213

Merged
merged 13 commits into from
Jan 6, 2022
Merged

Remove python.pythonPath experiment #18213

merged 13 commits into from
Jan 6, 2022

Conversation

karrtikr
Copy link

Closes #17977

@karrtikr karrtikr changed the title Remove DeprecatePythonPath experiment Remove python.pythonPath experiment Dec 21, 2021
@karrtikr karrtikr force-pushed the removepythonpathexp branch from e7d3de9 to e73d548 Compare January 6, 2022 13:11
@karrtikr karrtikr force-pushed the removepythonpathexp branch from 8535dbc to 9148437 Compare January 6, 2022 13:14
@karrtikr karrtikr added the skip package*.json package.json and package-lock.json don't both need updating label Jan 6, 2022
@karrtikr karrtikr marked this pull request as ready for review January 6, 2022 15:10
@karrtikr karrtikr merged commit 381a6e0 into microsoft:main Jan 6, 2022
@karrtikr karrtikr deleted the removepythonpathexp branch January 6, 2022 18:10
This was referenced Jan 6, 2022
Merged
Closed
@NorthIsUp
Copy link

What is the new way to specify the interpreter for a workspace?

@karrtikr
Copy link
Author

karrtikr commented Jan 8, 2022

You can do using python.defaultInterpreterPath setting. It's a little different from python.pythonPath at workspace level. Check the wiki https://github.com/microsoft/vscode-python/wiki/AB-Experiments#tldr to understand how it works.

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@wesm
Remove python.pythonPath experiment (microsoft/vscode-python#18213)
9ef4e58 
* Remove DeprecatePythonPath experiment

* Fix unit tests

* Fix tests for configsettings

* Fix mac interpreter tests

* Fix activation manager tests

* Fix config service tests

* Fix startup telemetry tests

* Remove all traces of experiment

* Fix python path updater tests

* Update setting description for `python.defaultInterpreterPath`

* Fix single workspace tests attempt#1

* Do not import from client folder in smoke tests

* new enttry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karrtikr karrtikr

Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove python.pythonPath setting and pythonDeprecatePythonPath experiment
2 participants
@karrtikr @NorthIsUp