Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create environment button to requirements.txt and pyproject.toml files #20813

Closed
wants to merge 2 commits into from
Closed

Add create environment button to requirements.txt and pyproject.toml files #20813

wants to merge 2 commits into from

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 8, 2023 •
edited
Loading

Closes #20812
Related #20133

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Mar 8, 2023
@karthiknadig karthiknadig self-assigned this Mar 8, 2023
@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Mar 8, 2023
@karthiknadig karthiknadig requested a review from karrtikr March 8, 2023 04:09
@karthiknadig karthiknadig marked this pull request as ready for review March 8, 2023 04:09
@vscodenpa vscodenpa added this to the March 2023 milestone Mar 8, 2023
@karthiknadig karthiknadig marked this pull request as draft March 8, 2023 19:05
@karthiknadig
Copy link
Member Author

Merge: Please wait for the distro update on VS Code, and VS Code needs to ship stable with that distro update before this can be merged.

@karrtikr karrtikr removed their request for review March 8, 2023 19:07
karrtikr
karrtikr previously approved these changes Mar 8, 2023
View reviewed changes
@karthiknadig karthiknadig marked this pull request as ready for review March 9, 2023 22:21
@karthiknadig karthiknadig requested a review from karrtikr March 9, 2023 22:21
karrtikr
karrtikr reviewed Mar 10, 2023
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However merging this would mean we would stop publishing any pre-releases for VSCode stable 1.76. We often ask users to try out pre-releases for some of the fixes we make, so we should wait until end of feature week before this is merged.

@karthiknadig
Copy link
Member Author

There are merge conflicts with this PR. I pushed an update but looks like something is broken with github. I will have to create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

Add create env command button to related files
3 participants
@karthiknadig @karrtikr @vscodenpa