Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notification when deactivate command is run in terminal #22133

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Show notification when deactivate command is run in terminal #22133

merged 12 commits into from
Oct 4, 2023

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Oct 2, 2023

Closes #22121

@karrtikr karrtikr added feature-request Request for new features or functionality skip package*.json package.json and package-lock.json don't both need updating labels Oct 2, 2023
@karrtikr karrtikr force-pushed the kartik/lovely-hummingbird branch from 5674245 to b274029 Compare October 3, 2023 23:52
@karrtikr karrtikr added the skip tests Updates to tests unnecessary label Oct 4, 2023
@karrtikr karrtikr force-pushed the kartik/lovely-hummingbird branch from 62335eb to 57692a1 Compare October 4, 2023 19:28
@karrtikr karrtikr marked this pull request as ready for review October 4, 2023 19:52
@karrtikr karrtikr removed the skip tests Updates to tests unnecessary label Oct 4, 2023
@karrtikr karrtikr enabled auto-merge (squash) October 4, 2023 21:24
@karrtikr karrtikr merged commit 66cea21 into main Oct 4, 2023
49 checks passed
@karrtikr karrtikr deleted the kartik/lovely-hummingbird branch October 4, 2023 23:29
karrtikr pushed a commit that referenced this pull request Oct 5, 2023
Revert "Show notification when deactivate command is run in terminal (#…
09cb112 
…22133)"

This reverts commit 66cea21.
@karrtikr karrtikr added no-changelog No news entry required and removed feature-request Request for new features or functionality labels Oct 5, 2023
@karrtikr karrtikr mentioned this pull request Oct 5, 2023
Merged
karrtikr pushed a commit that referenced this pull request Oct 5, 2023
Revert "Show notification when deactivate command is run in terminal" (…
514bce6 
…#22158)

Reverts #22133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@karrtikr karrtikr

Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show notification when deactivate command is run in terminal
2 participants
@karrtikr @roblourens