Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization failure for pre-release #22639

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix localization failure for pre-release #22639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/client/logging/settingLogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ async function notifyLegacySettings(): Promise<void> {
_isShown = true;
const response = await showWarningMessage(
l10n.t(
`You have deprecated linting or formatting settings for Python. Please see the [logs](command:${Commands.ViewOutput}) for more details.`,
'You have deprecated linting or formatting settings for Python. Please see the [logs](command:{0}) for more details.',
Commands.ViewOutput,
),
Common.learnMore,
);
Expand Down
2 changes: 1 addition & 1 deletion src/client/pythonEnvironments/creation/common/installCheckUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function parseDiagnostics(data: string): Diagnostic[] {
diagnostics = raw.map((item) => {
const d = new Diagnostic(
new Range(item.line, item.character, item.endLine, item.endCharacter),
l10n.t(`Package \`${item.package}\` is not installed in the selected environment.`),
l10n.t('Package `{0}` is not installed in the selected environment.', item.package),
item.severity,
);
d.code = { value: item.code, target: Uri.parse(`https://pypi.org/p/${item.package}`) };
Expand Down
3 changes: 2 additions & 1 deletion src/test/terminals/codeExecution/smartSend.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ suite('REPL - Smart Send', () => {
l10n.t(
`Python is unable to parse the code provided. Please
turn off Smart Send if you wish to always run line by line or explicitly select code
to force run. [logs](command:${Commands.ViewOutput}) for more details.`,
to force run. [logs](command:{0}) for more details.`,
Commands.ViewOutput,
),
'Switch to line-by-line',
),
Expand Down
Loading