prevent test.only #24235
Merged
prevent test.only #24235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
added
debt
anthonykim1
reviewed
Oct 3, 2024
| "plugins": [ | ||
| "@typescript-eslint", | ||
| "no-only-tests" | ||
| ], |
There was a problem hiding this comment.
I had #24161 with
"mocha/no-exclusive-tests": "error"
Is the one mentioned in this PR more general? I don't know which one is necessarily better/ more broader.
There was a problem hiding this comment.
as long as it works in the python ext correctly, we should probably use yours if it matches with what vscode is doing
There was a problem hiding this comment.
vscode had something like
"local/code-no-test-only": "error",
but I couldnt figure out where the part ""local/code" was coming from, and just saw/tested with mocha/no-execlusive-tests works. I think we can still use your no-only-tests though. For me that looks more generalized/better since we seem to have combination of different tests in Python repo.
anthonykim1
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I almost checked in a change to disable all tests again. This will prevent that