Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt Native REPL in Terminal #24477

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Nov 22, 2024

Resolves: #24270

Using two memento: global and workspace.

  • Global is used so if user clicks on do not show again, native repl suggestion will not show up ever again even after reloading.
  • Workspace will be used so only single suggestion prompt shows up in the terminal (remains unaggressive) PER non-reloaded VS Code window instance.

FYI) Problem exists with: user starting terminal Python REPL with 'Start Terminal REPL'. If they type exit, it still shows 'Python' and shift+enter will still send code to the shell which is now outside of Python shell. Bug: #22547

In future could also additionally leverage or alternatively use proposed Terminal Quick Fix API: https://github.com/microsoft/vscode/blob/3f3394a6e60850a7cd8578c5149bf34ab3157cf8/src/vscode-dts/vscode.proposed.terminalQuickFixProvider.d.ts

@anthonykim1 anthonykim1 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-repl labels Nov 22, 2024
@anthonykim1 anthonykim1 self-assigned this Nov 22, 2024
// TODO: Prompt user to start Native REPL

// If yes, then launch native REPL
await commandManager.executeCommand(Commands.Start_Native_REPL, undefined);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question is, do I really need the URI and pass it in? It seems like its used for await getActiveInterpreter(resource!, this.interpreterService); but works fine in extension host.
Perhaps this is because interpreter has already been pre-selected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the executeCommand API from src\client\common\vscodeApis\commandApis.ts

I was speaking to Daniel. Could we just put the use native REPL in the Shell welcome message? The REPL part can be turned into a link that launches the REPL. We can start with a not so in your face message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API, in terminal shell options:
image

Copy link
Author

@anthonykim1 anthonykim1 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting, challenge would be supporting the opening of a link to open the Native REPL though.
I made it so it prompt only shows once per non-reloaded session of VS Code and also pressing do not show will never show the suggestion again across VS Code instances (even after reloading).

Maybe we can start with the message and later add the link as well? I think the more visibility we can offer, the better it will be. /cc @cwebster-99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt for Native REPL when user types python in terminal
2 participants