-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests generated by plugins (like pep8) for discovery command. #8242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8242 +/- ##
==========================================
+ Coverage 59.04% 59.37% +0.32%
==========================================
Files 509 509
Lines 23299 23299
Branches 3758 3763 +5
==========================================
+ Hits 13758 13833 +75
+ Misses 8642 8567 -75
Partials 899 899
Continue to review full report at Codecov.
|
f74433a
to
a40d34b
Compare
The changes look good, might need a rebase to master to get around the test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with a mild caution)
Update upstream
To do not fail on discovery command and do not track their results.
FWIW, I am fairly sure that the old code (parsing the pytest CLI output) used to ignore plugin-generated nodes. If it matters then we can investigate in #8425. |
To do not fail on discovery command and do not track their results.
For #7287
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)