#47: Port the revision JSON view action.

middlebury · Dec 19, 2024 · 2d33158 · 2d33158
1 parent 775bf21
commit 2d33158
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 65 deletions.
diff --git a/application/controllers/ExportController.php b/application/controllers/ExportController.php
diff --git a/application/views/scripts/export/viewjson.phtml b/application/views/scripts/export/viewjson.phtml
diff --git a/src/Controller/AdminExports.php b/src/Controller/AdminExports.php
@@ -130,21 +130,17 @@ public function revisiondiffAction(int $rev1, int $rev2)
      *
      * @since 1/25/18
      */
-    #[Route('/admin/exports/revision/{revisionId}.json', name: 'admin_exports_config_revision_json')]
+    #[Route('/admin/exports/revision/{revisionId}/json', name: 'admin_exports_config_revision_json')]
     public function viewjsonAction(int $revisionId)
     {
-        $request = $this->getRequest();
-        if (!$request->getParam('revision') || -1 === $request->getParam('revision')) {
-            header('HTTP/1.1 400 Bad Request');
-            echo 'This route requires a revision ID';
-            exit;
-        }
-
-        $db = Zend_Registry::get('db');
+        $db = $this->entityManager->getConnection();
         $query = 'SELECT * FROM archive_configuration_revisions WHERE id = ?';
         $stmt = $db->prepare($query);
-        $stmt->execute([filter_var($request->get('revision'), \FILTER_SANITIZE_NUMBER_INT)]);
-        $data['revision'] = $stmt->fetch();
+        $stmt->bindValue(1, $revisionId);
+        $result = $stmt->executeQuery();
+        $data['rev'] = $result->fetchAssociative();
+
+        return $this->render('admin/export/revisionjson.html.twig', $data);
     }
 
     /**

diff --git a/templates/admin/export/revisionjson.html.twig b/templates/admin/export/revisionjson.html.twig
@@ -0,0 +1,6 @@
+{% extends 'base.html.twig' %}
+
+{% block body %}
+<h1>Viewing revision #{{ rev.id }} ({{ rev.last_saved }})</h1>
+<pre>{{ rev.json_data }}</pre>
+{% endblock %}