Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets are optional #55

Merged
merged 2 commits into from
Dec 1, 2024
Merged

secrets are optional #55

merged 2 commits into from
Dec 1, 2024

Conversation

dvdlevanon-miggo
Copy link
Contributor

Solving the problem for customers who manage their own secrets in their own way:

See the following for example:

image:
  registry: customer-own-registory/k8s-read

miggo:
  tenantId: "0654a211-37ca-7a9f-8000-f111e59b1c7f" # dev-test
  projectId: "f8fe49bb-b2eb-4a6e-9735-cee5ee472641"
  name: "test"

output:
  otlp:
    otlpEndpoint: "https://collector.staging.miggo.io:4317"

extraEnvs:
- name: K8S_READ_METRIC_OTLP_AUTH_HEADER
  value: Basic <masked>
- name: K8S_READ_OTLP_AUTH_HEADER
  value: Basic <masked>

The customer use its own docker registry, so no need for imagePullSecrets at all. In addition the user pass the otlp auth header directly to the POD, no need for the otlp-secret.

The PR just making sure that in that scenario we don't try to create or use non-existing secret.

@dvdlevanon-miggo dvdlevanon-miggo self-assigned this Dec 1, 2024
@dvdlevanon-miggo dvdlevanon-miggo merged commit 562a6fc into main Dec 1, 2024
@dvdlevanon-miggo dvdlevanon-miggo deleted the secrets-are-optional branch December 1, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants