Refactor Extension Interface #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes refactor the extension interface into a single protocol that provides access to the library handle and the getProcAddr function, giving the implementation more flexibility in providing these to the bindings.
migueldeicaza
added a commit
that referenced
this pull request
Nov 15, 2024
This reverts commit cd9821f.
|
This broke the build, but the other problem is that it introduced an "import GDExtension" when we use "@_implementationOnly import GDExtension" everywhere else. |
Closed
|
I have recreated the PR with the necessary changes: #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes refactor the extension interface into a single protocol that provides access to the library handle and the getProcAddr function, giving the implementation more flexibility in providing these to the bindings.