fix nTime conversion #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument of parseInt should be string, not buffer. Without this fix there is possible the case in which shares will be rejected with `ntime out of range`. Small example: // string f7b40161 <Buffer f7 b4 01 61> // 10 1627501815 1627501827 For nTime = "f7b40161" , nTimeInt will be equal 10, which is totally incorrect. More details available here: DeckerSU/node-stratum-pool@796410e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument of parseInt should be string, not buffer.
Without this fix there is possible the case in which shares will
be rejected with
ntime out of range.Small example:
For
nTime = "f7b40161",nTimeIntwill be equal10, which is totally incorrect.More details available here:
DeckerSU/node-stratum-pool@796410e