[Test PR] Verify manager-3.3 branch pre-commit check fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manager's _generate_load method has been worked to take keyspace_name as a parameter instead of keyspace_name_to_replace. That allows to generate the load for specific keyspace and makes the code more clear and understandable. assemble_and_run_all_stress_cmd_by_ks_names method was introduced to run stress commands for keyspaces with provided names. It was decided to keep it as separate method to not overcomplicate the existing one (assemble_and_run_all_stress_cmd). (cherry picked from commit b2b76a4)
Extend create_keyspace method to include tablets configuration to disable tablets (currently enabled by default) and provide initial number of tablets. (cherry picked from commit 5681a09)
There is no system_auth ks in Scylla with enabled raft topology. Thus, the test should check whether consistent topology changes are enabled or not to form the valid list of repaired keyspaces. (cherry picked from commit 486b5a8)
The new test performs sanity checks for cluster consisting of vnodes and tablets simultaneously. (cherry picked from commit b2cd1ca)
2 tasks
mikliapko
pushed a commit
that referenced
this pull request
Dec 6, 2024
…rom 3 to 4 As observed in a couple of new gemini runs [#6](https://argus.scylladb.com/tests/scylla-cluster-tests/f0c504cb-4bf5-47d4-a6bb-f0a102ec7fe4) [scylladb#7](https://argus.scylladb.com/tests/scylla-cluster-tests/26276989-e33c-40f1-9e94-788a4d824344) [#4](https://argus.scylladb.com/tests/scylla-cluster-tests/193e537e-e025-4857-86db-2156cd870fc3) [#2] https://argus.scylladb.com/tests/scylla-cluster-tests/41d1290a-1998-4bf4-9d15-4b21ad98cff9 Gemini's failures are caused by not having enough nodes in the test DB when cluster in run with Tablets, and by that we cannot establish quorum. This PR increases the number of nodes in the test DB to 4 in all relevant cases with nemesis. Signed-off-by: Dusan Malusev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)