static -> extern

mikolasan · Sep 6, 2024 · 44fdb25 · 44fdb25 · mikolasan · Sep 6, 2024
1 parent ad74bb9
commit 44fdb25
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 20 deletions.
diff --git a/basics/global/somewhere.cpp b/basics/global/somewhere.cpp
@@ -1,6 +1,6 @@
 #include "somewhere.h"
 
-// int ggg::global_variable = 1; // redefinition of ‘int ggg::global_variable’
+int ggg::global_variable = 1; // redefinition of ‘int ggg::global_variable’
 // ggg::global_variable = 1; // ‘global_variable’ in namespace ‘ggg’ does not name a type
 
 int mmm::global_variable_that_works = 1;
diff --git a/basics/global/somewhere.h b/basics/global/somewhere.h
@@ -1,6 +1,6 @@
 
 namespace ggg {
-static int global_variable = 1;
+extern int global_variable;
 }
 
 class mmm {

diff --git a/cryptography/sha-test.cpp b/cryptography/sha-test.cpp
@@ -74,25 +74,25 @@ digest_array sha256(const std::vector<char>& input)
 // }
 
 // deprecated version
-// std::string_view sha256(const std::list<std::string_view>& input)
-// {
-//     SHA256_CTX context;
-//     if (SHA256_Init(&context) == 0) {
-//         std::cerr << "sha256 context init failed" << std::endl;
-//     }
+std::string_view sha256_deprecated(const std::list<std::string_view>& input)
+{
+    SHA256_CTX context;
+    if (SHA256_Init(&context) == 0) {
+        std::cerr << "sha256 context init failed" << std::endl;
+    }
 
-//     for (const auto& i : input) {
-//         if (SHA256_Update(&context, i.data(), i.size()) == 0) {
-//             std::cerr << "sha256 update failed" << std::endl;
-//         }
-//     }
+    for (const auto& i : input) {
+        if (SHA256_Update(&context, i.data(), i.size()) == 0) {
+            std::cerr << "sha256 update failed" << std::endl;
+        }
+    }
 
-//     std::array<unsigned char, SHA256_DIGEST_LENGTH> digest;
-//     if (SHA256_Final(digest.data(), &context) == 0) {
-//         std::cerr << "sha256 final failed" << std::endl;
-//     }
-//     return std::string_view(digest.begin(), digest.end());
-// }
+    std::array<unsigned char, SHA256_DIGEST_LENGTH> digest;
+    if (SHA256_Final(digest.data(), &context) == 0) {
+        std::cerr << "sha256 final failed" << std::endl;
+    }
+    return std::string_view(digest.begin(), digest.end());
+}
 
 int main(int argc, char const *argv[])
 {

diff --git a/src/basics/README.md b/src/basics/README.md
@@ -7,7 +7,7 @@ Like really global global variable that is defined in one compilation unit but c
 **somewhere.h**
 
 ```cpp
-static int global_variable;
+extern int global_variable;
 ```
 
 **somewhere.cpp**
@@ -24,3 +24,5 @@ void foo()
     global_variable = 2;
 }
 ```
+
+## Heap VS stack