meowgli's tweak https://github.com/milkytracker/MilkyTracker/issues/304 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression bug which was introduced after keyjazz got implemented 477e611.
It resulted in a bug which retriggered a sample (which has a pingpong/forward loop set) rapidly (as soon as the end of the sample was reached).
If you test this with a looped pad-sample (and holding key 'q'), you'll notice that with this 'fix' the note now sustains properly (including looping).
I've tested the note-offs and they worked well too (so no regression), it's quite comfortable to play/records notes now.
Big thanks to moewgli #304