-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove stride's ICA liquid staking modules #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, however could you please split the changes that are not related to the removal of the modules (the addition of ratelimit
and the typo fixes) in another PR please?
This because I would like to keep the commit in the main
branch to only deal with the removal, so that if we ever need to revert it we don't affect anything else (e.g. by removing the added key).
Oh I didn't notice that I accidentally included the typo fix. Also I just realized that I removed the whole ICA functionality which is not this PR meant to. I'll force-push changes again. |
@hallazzang Removing the ICA funcionality is fine. We can have another PR for that though 👍 |
I'll be focusing on removing Stride's code in this PR. Let's remove ICA in another PR. Also, I didn't add |
4ae4737
to
66c17fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hallazzang Please take care of creating a new PR to remove the ICA modules. Thanks!
Description
Closes: MILK-151
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change