Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace"vested" terminology with "locked" #205

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Nov 26, 2024

Description

This PR updates the x/liquidvesting module to replace the "vested" terminology with "locked" instead. This is to make it clearer that we are representing vesting (i.e. not yet vested, still locked) tokens rather than vested (i.e. which have completed the vesting period, unlocked) tokens.

Depends-On: #204


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM force-pushed the riccardom/fix-liquidvesting branch from 7547c6f to ad67a86 Compare November 26, 2024 06:44
@RiccardoM RiccardoM requested a review from hallazzang November 26, 2024 06:44
@RiccardoM RiccardoM merged commit 1833a94 into main Nov 26, 2024
17 checks passed
@RiccardoM RiccardoM deleted the riccardom/fix-liquidvesting branch November 26, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant