chore(tests): add restaking simulation tests #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoM
changed the title
hallazzang
requested changes
Dec 6, 2024
manu0466
force-pushed
the
manuel/restaking-simulation-tests
branch
from
37123c0 to
e623ddb
Compare
RiccardoM
reviewed
Dec 10, 2024
Comment on lines
139
to
140
| operatorsKeeper := opk.(*operatorskeeper.Keeper) | ||
| servicesKeeper := sk.(*serviceskeeper.Keeper) |
There was a problem hiding this comment.
What's the point of using interfaces as the params type, if you are going to cast them anyway? I think it's better to either:
- Require non-interface types directly as params, or
- Use interfaces everywhere
This way you don't have to downcast anything and it's easier to manage everything
| operator, found := operatorssimulation.GetRandomExistingOperator(r, ctx, operatorsKeeper, func(o operatorstypes.Operator) bool { | ||
| // Search a service that the operator has joined | ||
| for _, s := range services { | ||
| hasJoined, _ := k.HasOperatorJoinedService(ctx, o.ID, s.ID) |
There was a problem hiding this comment.
Instead of o and s I would suggest using names as operator and service to make it easier to read
| return simtypes.NoOpMsg(types.ModuleName, sdk.MsgTypeURL(msg), "could not get operators"), nil, nil | ||
| } | ||
|
|
||
| // Get a service and an operator that is not allowed |
There was a problem hiding this comment.
Suggested change
| // Get a service and an operator that is not allowed | |
| // Get a service and an operator that is inside the allow list |
hallazzang
requested changes
Dec 11, 2024
hallazzang
approved these changes
Dec 11, 2024
manu0466
force-pushed
the
manuel/restaking-simulation-tests
branch
from
d06d6bc to
34b6ab0
Compare
RiccardoM
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: MILK-150
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change