Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v4 upgrade handler #222

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Dec 17, 2024

Description

This PR adds the v4 upgrade handler that takes care of removing all markets and currency pairs from the x/marketmap and x/oracle modules except the ones that are related to TIA .

This was done in order to reduce the amount of data stored per each block, since we do not use any currency pair outside of TIA/USD and its derivates inside our modules.

Closes: MILK-179


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM requested a review from hallazzang December 17, 2024 01:37
Copy link

github-actions bot commented Dec 17, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 17, 2024, 2:56 AM

app/upgrades/v4/upgrades.go Outdated Show resolved Hide resolved
@RiccardoM RiccardoM requested a review from hallazzang December 17, 2024 02:58
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiccardoM RiccardoM merged commit b785a51 into main Dec 17, 2024
19 checks passed
@RiccardoM RiccardoM deleted the riccardom/add-v4-upgrade-handler branch December 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants