Skip to content

Commit

Permalink
enhance: remove the rpc level of coordinator (#37876)
Browse files Browse the repository at this point in the history
issue: #33285
pr: #37722

- move most cgo opeartions related to search/query into segcore package
for reusing for streamingnode.
- add go unittest for segcore operations.

Signed-off-by: chyezh <[email protected]>
  • Loading branch information
chyezh authored Nov 21, 2024
1 parent 99da46d commit 1a6b98b
Show file tree
Hide file tree
Showing 16 changed files with 2,439 additions and 42 deletions.
8 changes: 7 additions & 1 deletion cmd/milvus/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"go.uber.org/zap"

"github.com/milvus-io/milvus/cmd/roles"
"github.com/milvus-io/milvus/internal/coordinator/coordclient"
"github.com/milvus-io/milvus/internal/util/sessionutil"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/etcd"
Expand Down Expand Up @@ -171,7 +172,12 @@ func GetMilvusRoles(args []string, flags *flag.FlagSet) *roles.MilvusRoles {
fmt.Fprintf(os.Stderr, "Unknown server type = %s\n%s", serverType, getHelp())
os.Exit(-1)
}

coordclient.EnableLocalClientRole(&coordclient.LocalClientRoleConfig{
ServerType: serverType,
EnableQueryCoord: role.EnableQueryCoord,
EnableDataCoord: role.EnableDataCoord,
EnableRootCoord: role.EnableRootCoord,
})
return role
}

Expand Down
Loading

0 comments on commit 1a6b98b

Please sign in to comment.