Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rbac v2 grantor and error messages #38004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

fix rbac v2 grantor and error messages

9faa7b3
Select commit
Loading
Failed to load commit list.
Open

fix: fix rbac v2 grantor and error messages #38004

fix rbac v2 grantor and error messages
9faa7b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

82.97% (target 77.00%)

View this Pull Request on Codecov

82.97% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (27c22d1) to head (9faa7b3).

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 69.23% 3 Missing and 1 partial ⚠️
internal/proxy/impl.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38004       +/-   ##
===========================================
+ Coverage   68.87%   82.97%   +14.09%     
===========================================
  Files         289     1071      +782     
  Lines       25481   165301   +139820     
===========================================
+ Hits        17551   137160   +119609     
- Misses       7930    22665    +14735     
- Partials        0     5476     +5476     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.26% <82.14%> (∅)
Files with missing lines Coverage Δ
internal/proxy/util.go 89.97% <100.00%> (ø)
internal/proxy/impl.go 84.64% <0.00%> (ø)
internal/rootcoord/root_coord.go 89.44% <69.23%> (ø)

... and 1357 files with indirect coverage changes

---- 🚨 Try these New Features: