Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: the actual number of databases should equal the config value #38006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (e76802f) to head (b59184b).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38006      +/-   ##
==========================================
+ Coverage   79.00%   81.07%   +2.07%     
==========================================
  Files        1352     1360       +8     
  Lines      189537   190776    +1239     
==========================================
+ Hits       149739   154680    +4941     
+ Misses      34341    30615    -3726     
- Partials     5457     5481      +24     
Components Coverage Δ
Client 72.33% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.25% <100.00%> (+2.47%) ⬆️
Files with missing lines Coverage Δ
internal/rootcoord/create_db_task.go 84.21% <100.00%> (ø)

... and 256 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants