Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass simulation data via CSV file to explorer #1018

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidanthoff
Copy link
Collaborator

This might work better with large simulation data than the current approach. I only implemented it for one specific plot type. If this works we might also use this approach for other figures.

Also updated vega and vega-lite to their latest versions.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (9da9ce9) to head (f437479).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          40       40           
  Lines        4070     4072    +2     
=======================================
+ Hits         3453     3455    +2     
  Misses        617      617           
Flag Coverage Δ
unittests 84.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lrennels
Copy link
Collaborator

@davidanthoff from a code perspective this looks good to me, and all tests are passing. I also ran the test_explorer_sim.jl test file locally and looked at outputs to make sure things looked ok and they do as far as I can tell.

In terms of improvement to performance we should test with a model that has a fine grained spatial dimension, like countries (GIVE) or even coastal segments (CIAM). I think @corakingdon has an example case, but I can give it a try too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants