-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Release using changesets #60 #66
Conversation
🦋 Changeset detectedLatest commit: 3db93f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update enhances the project’s versioning and release processes through the integration of Changesets, improved GitHub Actions workflows, and structured package configurations. Key additions include a new release automation workflow, updated dependencies for caching and checkout actions, and organized publishing configurations across packages. Overall, these changes aim to streamline development and maintain an efficient package management system. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant CI as CI/CD Pipeline
participant NPM as NPM Registry
Dev->>GH: Push code to main branch
GH->>CI: Trigger release workflow
CI->>GH: Checkout code
CI->>CI: Setup Node.js environment
CI->>CI: Run Changesets to create release pull request or publish
CI->>NPM: Publish package
NPM-->>CI: Confirm publish
CI->>GH: Create release
GH-->>Dev: Notify release complete
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Triggered from #66 by @black7375. Checking if we can fast forward Target branch ( commit 550e404cf7a55978b405ed67d5198cc2da5127bb (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Thu Aug 15 18:49:54 2024 +0900
Docs: README update #60 Pull request ( commit 3db93f706ee39bd4365891e5c8fd25c66609a99f (pull_request/publish/css)
Author: alstjr7375 <[email protected]>
Date: Thu Aug 15 23:40:10 2024 +0900
Chore: Release workflow #60 It is possible to fast forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (11)
- .changeset/README.md (1 hunks)
- .changeset/config.json (1 hunks)
- .changeset/proud-poets-turn.md (1 hunks)
- .github/actions/node-setup/action.yml (1 hunks)
- .github/workflows/ci.yml (2 hunks)
- .github/workflows/release.yml (1 hunks)
- package.json (2 hunks)
- packages/css-additional-types/package.json (1 hunks)
- packages/css/package.json (1 hunks)
- packages/debug-log/package.json (1 hunks)
- packages/transform-to-vanilla/package.json (1 hunks)
Files skipped from review due to trivial changes (4)
- .changeset/README.md
- .changeset/config.json
- .changeset/proud-poets-turn.md
- packages/transform-to-vanilla/package.json
Additional comments not posted (14)
.github/actions/node-setup/action.yml (1)
13-13
: Verify compatibility withactions/cache@v4
.The update from
actions/cache@v3
tov4
may introduce changes in behavior or features. Ensure that the new version is compatible with your workflow and that any new features or changes are appropriately handled.Verification successful
No compatibility issues found with
actions/cache@v4
. The update includes a bug fix forfail-on-cache-miss
without any breaking changes or new features that impact your workflow.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility and changes in `actions/cache@v4`. # Test: Check for any breaking changes or new features in `actions/cache@v4`. # Expect: No breaking changes that affect current usage. gh api repos/actions/cache/releases/latest --jq '.tag_name'Length of output: 66
Script:
#!/bin/bash # Description: Retrieve release notes for `actions/cache@v4` to check for breaking changes or new features. # Fetch the release notes for the latest v4 release. gh api repos/actions/cache/releases/tags/v4.0.2 --jq '.body'Length of output: 257
.github/workflows/ci.yml (1)
13-13
: Verify compatibility withactions/checkout@v4
.The update from
actions/checkout@v3
tov4
may introduce changes in behavior or features. Ensure that the new version is compatible with your workflow and that any new features or changes are appropriately handled.Also applies to: 30-30
.github/workflows/release.yml (1)
1-37
: Review the new release workflow configuration.The new release workflow is set up to create release pull requests or publish to npm using changesets. Ensure that:
- The permissions are correctly set for the required actions.
- The
GITHUB_TOKEN
andNPM_TOKEN
secrets are correctly configured in the repository settings.- The
changesets/action@v1
is correctly configured to meet your release requirements.packages/css-additional-types/package.json (1)
35-37
: Approve the addition ofpublishConfig
.The
publishConfig
section specifying the directory for publishing enhances the package's release process by organizing the output directory. This change aligns with the PR's objective of improving release management.packages/css/package.json (1)
46-48
: Approve the addition ofpublishConfig
.The
publishConfig
section specifying the directory for publishing enhances the package's release process by organizing the output directory. This change aligns with the PR's objective of improving release management.packages/debug-log/package.json (1)
42-44
: Approve the addition ofpublishConfig
.The
publishConfig
section specifying the directory for publishing enhances the package's release process by organizing the output directory. This change aligns with the PR's objective of improving release management.package.json (8)
24-24
: LGTM! Theforallpackages
script is a useful addition.This script enhances workspace management by executing commands across all packages efficiently.
25-25
: LGTM! Thebuild:release
script effectively consolidates build and release steps.This script simplifies the release workflow by automating build, clean, and package operations.
26-26
: LGTM! Thechangeset
script is a straightforward addition.This script facilitates version control and changelog generation.
27-27
: LGTM! Theversion
script automates the versioning process.This script ensures that package versions are updated based on changesets.
28-28
: LGTM! Thepublish
script effectively integrates build and release processes.This script ensures a streamlined and documented release process by combining build and changeset publishing steps.
29-29
: LGTM! Theg:clean
script modification helps maintain a clean workspace.Including the
_release
directory in the cleanup process ensures a tidy build environment.
43-43
: LGTM! The@changesets/changelog-github
dependency is a valuable addition.This dependency aids in generating changelogs with GitHub integration, enhancing release note clarity.
44-44
: LGTM! The@changesets/cli
dependency is essential for changeset management.This dependency supports versioning and changelog generation, crucial for project maintenance.
/fast-forward |
Triggered from #66 (comment) by @black7375. Trying to fast forward Target branch ( commit 550e404cf7a55978b405ed67d5198cc2da5127bb (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <[email protected]>
Date: Thu Aug 15 18:49:54 2024 +0900
Docs: README update #60 Pull request ( commit 3db93f706ee39bd4365891e5c8fd25c66609a99f (pull_request/publish/css)
Author: alstjr7375 <[email protected]>
Date: Thu Aug 15 23:40:10 2024 +0900
Chore: Release workflow #60 Fast forwarding $ git push origin 3db93f706ee39bd4365891e5c8fd25c66609a99f:main
To https://github.com/mincho-js/mincho.git
550e404..3db93f7 3db93f706ee39bd4365891e5c8fd25c66609a99f -> main |
Description
Release using changesets.
Related Issue
@mincho-js/css
package #60Summary by CodeRabbit
New Features
Enhancements
package.json
for efficient build and release processes.Bug Fixes
Documentation
Additional context
Checklist