Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for historical time series data #8

Merged
merged 10 commits into from
Feb 4, 2024
Merged

feat: Support for historical time series data #8

merged 10 commits into from
Feb 4, 2024

Conversation

arvindrajan92
Copy link
Contributor

Hi @mindmelting, I am adding support for retrieving historical time series data without breaking get_data() method.

@mindmelting
Copy link
Owner

mindmelting commented Jan 27, 2024

@arvindrajan92 thanks for the PR (and sorry for the delay!)

Would you mind adding to the README (and expanding the unit tests) to cover usage of start, end and sample arguments for the new method and example values for these?

(Also fixing up the failing flake8 lint errors!)

Thanks!

@arvindrajan92
Copy link
Contributor Author

@arvindrajan92 thanks for the PR (and sorry for the delay!)

Would you mind adding to the README (and expanding the unit tests) to cover usage of start, end and sample arguments for the new method and example values for these?

(Also fixing up the failing flake8 lint errors!)

Thanks!

@mindmelting no worries, and you're welcome :)

I have expanded the unit test with more test cases and updated README.md. The flake8 lint errors should be fixed now. Please let me know if you get any more errors. Thanks

@arvindrajan92
Copy link
Contributor Author

@mindmelting doesn't seem like an error I could fix from my end. hope you could take a look at it. thanks for spending some time looking into this - sincerely appreciate it :)

@mindmelting
Copy link
Owner

Will take a look this weekend, thanks!

@mindmelting
Copy link
Owner

@arvindrajan92 I have fixed the build issue - are you able to bump the version to 0.4.0 and I can then merge and publish it to pypi

@arvindrajan92
Copy link
Contributor Author

@arvindrajan92 I have fixed the build issue - are you able to bump the version to 0.4.0 and I can then merge and publish it to pypi

@mindmelting done 😄

@mindmelting mindmelting self-requested a review February 4, 2024 08:53
@mindmelting mindmelting merged commit 121d254 into mindmelting:main Feb 4, 2024
1 check passed
@arvindrajan92 arvindrajan92 deleted the time-series branch February 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants