Switch mapgen to using biomes (still with backwards compatibility) #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the original mapgen code to
mapgen_nobiomes.lua
, and provides an MT5 biomes-based equivalent mapgen inmapgen.lua
. Both mapgens use paramat's cave noise. The old mapgen is loaded in v6 worlds and versions of MT prior to 5.1My own reason for the change is I want to add a lot to the Nether, and getting it working with biomes API, ores API etc provides a better platform to build on.
However, this PR provides many other advantages:
Things to note:
override_underground_biomes()
will shift biomes that overlap the Nether, this includes many of the MTG biomes such as "savanna_under" which extend from -256 to -31000Tips to make evaluating the changes easier:
node_cave_liquid = "air"
in the nether_caverns biome definition). Vet normally the new code in mapgen.lua for setting up biomes and excavating dungeons.Git flow?
Rather than end up with a massive PR like the Portals API, would the maintainers of this mod prefer a dev branch, and approve/merge in smaller PRs like this one into it. Then when I'm ready for the changes to go into master there's no review/testing needed?
(though I'm also quite happy to just keep adding to a branch and have a massive PR at the end)