This repository has been archived by the owner on May 13, 2024. It is now read-only.
CFileSystem: Fix signed integer conversion on MinGW #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Feb 18, 2024
appgurueu
reviewed
Feb 18, 2024
|
Retested the |
|
FYI @mzeilfelder Although I did not test upstream Irrlicht yet, it is likely that the file picker dialogue will show the same crash issue on 64-bit MinGW builds. Letting you know in case there's already such issues reported. |
|
Thanks, but upstream still using 'long' so it's fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes minetest/minetest#14381
How to test:
IrrlichtMt.dllfile of a comparably recent Minetest buildbot artifact.